From 7ef6fbaabc39289ee743811e4a62fedd343b8a8a Mon Sep 17 00:00:00 2001 From: Madhura Jayaratne Date: Sat, 12 Mar 2011 06:09:09 +0530 Subject: [PATCH 1/5] Fix highlighting for save/hide of inline-edit --- js/sql.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/js/sql.js b/js/sql.js index 9b5edf99d..b513ffb28 100644 --- a/js/sql.js +++ b/js/sql.js @@ -441,6 +441,8 @@ $(document).ready(function() { $this_children.text(PMA_messages['strInlineEdit']); var $this_hide = $(this).parent(); $this_hide.removeClass("inline_edit_active hover").addClass("inline_edit_anchor"); + $this_hide.parent().removeClass("hover"); + $this_hide.siblings().removeClass("hover"); var last_column = $this_hide.siblings().length; var txt = []; var blob_index = []; @@ -919,7 +921,9 @@ $(document).ready(function() { } PMA_ajaxShowMessage(data.message); - $this_td.removeClass('inline_edit_active').addClass('inline_edit_anchor'); + $this_td.removeClass('inline_edit_active hover').addClass('inline_edit_anchor'); + $this_td.parent().removeClass('hover') + $this_td.siblings().removeClass('hover'); $input_siblings.each(function() { // Inline edit post has been successful. From 2e2474eb682f72389d90a9e5dbf8da32ec2ce1fe Mon Sep 17 00:00:00 2001 From: Madhura Jayaratne Date: Sat, 12 Mar 2011 07:52:45 +0530 Subject: [PATCH 2/5] Identify non inline-editable columns based on class 'inline_edit'. --- js/sql.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/sql.js b/js/sql.js index b513ffb28..dda174eed 100644 --- a/js/sql.js +++ b/js/sql.js @@ -448,7 +448,7 @@ $(document).ready(function() { var blob_index = []; var k = 0; for(var i = 4; i < last_column; i++){ - if($this_hide.siblings("td:eq(" + i + ")").children('a:eq(0)').length ){ + if($this_hide.siblings("td:eq(" + i + ")").hasClass("inline_edit") == false){ blob_index[k] = i; k++; continue; @@ -497,7 +497,7 @@ $(document).ready(function() { var blob_index = []; var k = 0; for( var i = 6; i <= rows + 2; i++){ - if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ") a:eq(0)").length !=0 ){ + if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").hasClass("inline_edit") == false){ blob_index[k] = i; k++; continue; From 0068d42f73a1493d2ea05f729b2b7fa0afd80367 Mon Sep 17 00:00:00 2001 From: Madhura Jayaratne Date: Sat, 12 Mar 2011 07:59:29 +0530 Subject: [PATCH 3/5] Optimize. We can do what is being done in two for-loops in one for-loop and avoid unnecessary temporary variables. --- js/sql.js | 36 +++++++----------------------------- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/js/sql.js b/js/sql.js index dda174eed..2f0256a79 100644 --- a/js/sql.js +++ b/js/sql.js @@ -444,26 +444,15 @@ $(document).ready(function() { $this_hide.parent().removeClass("hover"); $this_hide.siblings().removeClass("hover"); var last_column = $this_hide.siblings().length; - var txt = []; - var blob_index = []; - var k = 0; + var txt = ''; for(var i = 4; i < last_column; i++){ if($this_hide.siblings("td:eq(" + i + ")").hasClass("inline_edit") == false){ - blob_index[k] = i; - k++; - continue; - } - txt[i - 4] = $this_hide.siblings("td:eq(" + i + ")").children(' .original_data').html(); - } - k = 0; - for (var i = 4; i < last_column; i++){ - if ( blob_index[k] == i){ - k++; continue; } + txt = $this_hide.siblings("td:eq(" + i + ")").children(' .original_data').html(); if($this_hide.siblings("td:eq(" + i + ")").children().length !=0){ $this_hide.siblings("td:eq(" + i + ")").empty(); - $this_hide.siblings("td:eq(" + i + ")").append(txt[i-4]); + $this_hide.siblings("td:eq(" + i + ")").append(txt); } } $(this).prev().prev().remove(); @@ -471,7 +460,7 @@ $(document).ready(function() { $(this).remove(); }); } else { - var txt=[]; + var txt=''; var rows=$(this).parent().siblings().length;; $(this).append(hide_link); @@ -494,24 +483,13 @@ $(document).ready(function() { $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active hover").addClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); } - var blob_index = []; - var k = 0; for( var i = 6; i <= rows + 2; i++){ - if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").hasClass("inline_edit") == false){ - blob_index[k] = i; - k++; - continue; - } - txt[i - 6] = $this_row.siblings("tr:eq(" + i + ") td:eq("+pos+") span.original_data").html(); - } - k = 0; - for (var i = 6; i <= rows + 2; i++){ - if(blob_index[k] == i){ - k++; + if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").hasClass("inline_edit") == false){ continue; } + txt = $this_row.siblings("tr:eq(" + i + ") td:eq("+pos+") span.original_data").html(); $this_row.siblings("tr:eq("+i+") td:eq("+pos+")").empty(); - $this_row.siblings("tr:eq("+i+") td:eq("+pos+")").append(txt[ i - 6]); + $this_row.siblings("tr:eq("+i+") td:eq("+pos+")").append(txt); } $(this).prev().remove(); $(this).prev().remove(); From ed00eea0a363f463a784a96caf5ddc0a702ea3c1 Mon Sep 17 00:00:00 2001 From: Madhura Jayaratne Date: Sat, 12 Mar 2011 08:09:46 +0530 Subject: [PATCH 4/5] Code formatting. Make the code more readable. --- js/sql.js | 48 +++++++++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/js/sql.js b/js/sql.js index 2f0256a79..3ebd9a8da 100644 --- a/js/sql.js +++ b/js/sql.js @@ -423,34 +423,36 @@ $(document).ready(function() { // looping through all columns or rows, to find the required data and then storing it in an array. var $this_children = $(this).children('span.nowrap').children('a').children('span.nowrap'); - if (disp_mode != 'vertical'){ + if (disp_mode != 'vertical') { $this_children.empty(); $this_children.text(PMA_messages['strSave']); } else { - // vertical + // vertical data_vt = $this_children.html(); $this_children.text(PMA_messages['strSave']); } var hide_link = '

' + PMA_messages['strHide'] + ''; - if (disp_mode != 'vertical'){ + if (disp_mode != 'vertical') { $(this).append(hide_link); - $('#table_results tbody tr td a#hide').click(function(){ + $('#table_results tbody tr td a#hide').click(function() { $this_children = $(this).siblings('span.nowrap').children('a').children('span.nowrap'); $this_children.empty(); $this_children.text(PMA_messages['strInlineEdit']); + var $this_hide = $(this).parent(); $this_hide.removeClass("inline_edit_active hover").addClass("inline_edit_anchor"); $this_hide.parent().removeClass("hover"); $this_hide.siblings().removeClass("hover"); + var last_column = $this_hide.siblings().length; var txt = ''; - for(var i = 4; i < last_column; i++){ - if($this_hide.siblings("td:eq(" + i + ")").hasClass("inline_edit") == false){ + for(var i = 4; i < last_column; i++) { + if($this_hide.siblings("td:eq(" + i + ")").hasClass("inline_edit") == false) { continue; } txt = $this_hide.siblings("td:eq(" + i + ")").children(' .original_data').html(); - if($this_hide.siblings("td:eq(" + i + ")").children().length !=0){ + if($this_hide.siblings("td:eq(" + i + ")").children().length != 0) { $this_hide.siblings("td:eq(" + i + ")").empty(); $this_hide.siblings("td:eq(" + i + ")").append(txt); } @@ -458,22 +460,20 @@ $(document).ready(function() { $(this).prev().prev().remove(); $(this).prev().remove(); $(this).remove(); - }); + }); } else { - var txt=''; - var rows=$(this).parent().siblings().length;; + var txt = ''; + var rows = $(this).parent().siblings().length; $(this).append(hide_link); - $('#table_results tbody tr td a#hide').click(function(){ - - var pos=$(this).parent().index(); - var $chg_submit=$(this).parent().children('span.nowrap').children('a').children('span.nowrap'); + $('#table_results tbody tr td a#hide').click(function() { + var pos = $(this).parent().index(); + var $chg_submit = $(this).parent().children('span.nowrap').children('a').children('span.nowrap'); $chg_submit.empty(); $chg_submit.append(data_vt); - - var $this_row=$(this).parent().parent(); - //alert(pos); - if(parseInt(pos)%2==0){ + + var $this_row = $(this).parent().parent(); + if(parseInt(pos) % 2 == 0) { $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active").addClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active hover").addClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); @@ -481,21 +481,19 @@ $(document).ready(function() { $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active").addClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active hover").addClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); - } for( var i = 6; i <= rows + 2; i++){ - if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").hasClass("inline_edit") == false){ + if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").hasClass("inline_edit") == false) { continue; } - txt = $this_row.siblings("tr:eq(" + i + ") td:eq("+pos+") span.original_data").html(); - $this_row.siblings("tr:eq("+i+") td:eq("+pos+")").empty(); - $this_row.siblings("tr:eq("+i+") td:eq("+pos+")").append(txt); + txt = $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ") span.original_data").html(); + $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").empty(); + $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").append(txt); } $(this).prev().remove(); $(this).prev().remove(); $(this).remove(); - - }); + }); } // Initialize some variables From f599afd843befcbe98771d0129bc2bb1405bdb4d Mon Sep 17 00:00:00 2001 From: Madhura Jayaratne Date: Sat, 12 Mar 2011 08:18:11 +0530 Subject: [PATCH 5/5] Proper indentation. --- js/sql.js | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/js/sql.js b/js/sql.js index 3ebd9a8da..1c46c056b 100644 --- a/js/sql.js +++ b/js/sql.js @@ -467,32 +467,32 @@ $(document).ready(function() { $(this).append(hide_link); $('#table_results tbody tr td a#hide').click(function() { - var pos = $(this).parent().index(); - var $chg_submit = $(this).parent().children('span.nowrap').children('a').children('span.nowrap'); - $chg_submit.empty(); - $chg_submit.append(data_vt); + var pos = $(this).parent().index(); + var $chg_submit = $(this).parent().children('span.nowrap').children('a').children('span.nowrap'); + $chg_submit.empty(); + $chg_submit.append(data_vt); - var $this_row = $(this).parent().parent(); - if(parseInt(pos) % 2 == 0) { - $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active").addClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); + var $this_row = $(this).parent().parent(); + if(parseInt(pos) % 2 == 0) { + $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active").addClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); - $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active hover").addClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); - } else { - $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active").addClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); + $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active hover").addClass("odd edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); + } else { + $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active").addClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); - $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active hover").addClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); + $this_row.siblings("tr:eq(3) td:eq(" + pos + ")").removeClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_active hover").addClass("even edit_row_anchor row_" + pos + " vpointer vmarker inline_edit_anchor"); + } + for( var i = 6; i <= rows + 2; i++){ + if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").hasClass("inline_edit") == false) { + continue; } - for( var i = 6; i <= rows + 2; i++){ - if( $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").hasClass("inline_edit") == false) { - continue; - } - txt = $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ") span.original_data").html(); - $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").empty(); - $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").append(txt); - } - $(this).prev().remove(); - $(this).prev().remove(); - $(this).remove(); + txt = $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ") span.original_data").html(); + $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").empty(); + $this_row.siblings("tr:eq(" + i + ") td:eq(" + pos + ")").append(txt); + } + $(this).prev().remove(); + $(this).prev().remove(); + $(this).remove(); }); }