bug #3042706 [pmadb] Relations, bookmarks, etc deleted after table drop

This commit is contained in:
Marc Delisle
2010-08-11 10:48:05 -04:00
parent ba038ed6e1
commit bda213a5ac
4 changed files with 13 additions and 2 deletions

View File

@@ -115,6 +115,7 @@ $Id$
thanks to Will Palmer - wpalmer thanks to Will Palmer - wpalmer
- bug #3040226 [XHTML] LockFromUpdate checkbox not checked by default - bug #3040226 [XHTML] LockFromUpdate checkbox not checked by default
- bug [doc] Withdraw or edit FAQ entries related to older MySQL or PHP - bug [doc] Withdraw or edit FAQ entries related to older MySQL or PHP
- bug #3042706 [pmadb] Relations, bookmarks, etc deleted after table drop
3.3.5.0 (2010-07-26) 3.3.5.0 (2010-07-26)
- patch #2932113 [information_schema] Slow export when having lots of - patch #2932113 [information_schema] Slow export when having lots of

View File

@@ -114,7 +114,10 @@ if (empty($GLOBALS['is_header_sent'])) {
__('New table'), __('New table'),
'', '',
's_tbl.png'); 's_tbl.png');
} elseif (strlen($GLOBALS['table'])) { // if the table is being dropped, $_REQUEST['purge'] is set
// (it always contains "1")
// so do not display the table name in upper div
} elseif (strlen($GLOBALS['table']) && ! (isset($_REQUEST['purge']))) {
require_once './libraries/tbl_info.inc.php'; require_once './libraries/tbl_info.inc.php';
echo $separator; echo $separator;

View File

@@ -530,7 +530,12 @@ if (0 == $num_rows || $is_affected) {
$goto = PMA_securePath($goto); $goto = PMA_securePath($goto);
// Checks for a valid target script // Checks for a valid target script
$is_db = $is_table = false; $is_db = $is_table = false;
if (isset($_REQUEST['purge'])) {
$table = '';
unset($url_params['table']);
}
include 'libraries/db_table_exists.lib.php'; include 'libraries/db_table_exists.lib.php';
if (strpos($goto, 'tbl_') === 0 && ! $is_table) { if (strpos($goto, 'tbl_') === 0 && ! $is_table) {
if (strlen($table)) { if (strlen($table)) {
$table = ''; $table = '';

View File

@@ -668,7 +668,9 @@ if (! (isset($db_is_information_schema) && $db_is_information_schema)) {
'reload' => '1', 'reload' => '1',
'purge' => '1', 'purge' => '1',
'zero_rows' => sprintf(($tbl_is_view ? __('View %s has been dropped') : __('Table %s has been dropped')), htmlspecialchars($table)), 'zero_rows' => sprintf(($tbl_is_view ? __('View %s has been dropped') : __('Table %s has been dropped')), htmlspecialchars($table)),
'table' => NULL, // table name is needed to avoid running
// PMA_relationsCleanupDatabase() on the whole db later
'table' => $GLOBALS['table'],
)); ));
?> ?>
<li><a href="sql.php<?php echo PMA_generate_common_url($this_url_params); ?>" onclick="return confirmLink(this, '<?php echo PMA_jsFormat($this_sql_query); ?>')"> <li><a href="sql.php<?php echo PMA_generate_common_url($this_url_params); ?>" onclick="return confirmLink(this, '<?php echo PMA_jsFormat($this_sql_query); ?>')">