code cleanup

This commit is contained in:
Marc Delisle
2009-12-26 13:46:53 +00:00
parent df8a359cff
commit bea5e54e79

View File

@@ -426,6 +426,32 @@ class PMA_Tracker
/**
* Changes tracking of a table.
*
* @static
*
* @param string $dbname name of database
* @param string $tablename name of table
* @param string $version version
* @param integer $new_state the new state of tracking
*
* @return int result of SQL query
*/
static private function changeTracking($dbname, $tablename, $version, $new_state)
{
$sql_query =
" UPDATE " . self::$pma_table .
" SET " . PMA_backquote('tracking_active') . " = '" . $new_state . "' " .
" WHERE " . PMA_backquote('db_name') . " = '" . PMA_sqlAddslashes($dbname) . "' " .
" AND " . PMA_backquote('table_name') . " = '" . PMA_sqlAddslashes($tablename) . "' " .
" AND " . PMA_backquote('version') . " = '" . PMA_sqlAddslashes($version) . "' ";
$result = PMA_query_as_controluser($sql_query);
return $result;
}
/**
* Activates tracking of a table.
*
@@ -439,21 +465,12 @@ class PMA_Tracker
*/
static public function activateTracking($dbname, $tablename, $version)
{
$sql_query =
" UPDATE " . self::$pma_table .
" SET " . PMA_backquote('tracking_active') ." = '1' " .
" WHERE " . PMA_backquote('db_name') . " = '" . PMA_sqlAddslashes($dbname) . "' " .
" AND " . PMA_backquote('table_name') . " = '" . PMA_sqlAddslashes($tablename) . "' " .
" AND " . PMA_backquote('version') . " = '" . PMA_sqlAddslashes($version) . "' ";
$result = PMA_query_as_controluser($sql_query);
return $result;
return self::changeTracking($dbname, $tablename, $version, 1);
}
/**
* Deativates tracking of a table.
* Deactivates tracking of a table.
*
* @static
*
@@ -465,16 +482,7 @@ class PMA_Tracker
*/
static public function deactivateTracking($dbname, $tablename, $version)
{
$sql_query =
" UPDATE " . self::$pma_table .
" SET " . PMA_backquote('tracking_active') ." = '0' " .
" WHERE " . PMA_backquote('db_name') . " = '" . PMA_sqlAddslashes($dbname) . "' " .
" AND " . PMA_backquote('table_name') . " = '" . PMA_sqlAddslashes($tablename) . "' " .
" AND " . PMA_backquote('version') . " = '" . PMA_sqlAddslashes($version) . "' ";
$result = PMA_query_as_controluser($sql_query);
return $result;
return self::changeTracking($dbname, $tablename, $version, 0);
}
@@ -488,7 +496,7 @@ class PMA_Tracker
* @param string $tablename name of table
* @param string $statement tracked statement
*
* @return int (-1 if no version exist | > 0 if a version exist)
* @return int (-1 if no version exists | > 0 if a version exists)
*/
static public function getVersion($dbname, $tablename, $statement = null)
{