From cddde7052c49e7cc50ec9e5eb72ba427b8fd03b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Chapeaux?= <lolo@phpheaven.net>
Date: Wed, 29 Aug 2001 07:43:41 +0000
Subject: [PATCH] optimized the 'check_rights()' function

---
 ChangeLog         |  1 +
 user_details.php3 | 30 +++++++++++++++++++-----------
 2 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index eaea4ed1f..4f73a8abc 100755
--- a/ChangeLog
+++ b/ChangeLog
@@ -11,6 +11,7 @@ $Source$
 	  main.php3; sql.php3; tbl_properties.php3; tbl_select.php3;
 	  tbl_replace.php3: the $server variable do not need to be urlencoded (it's
 	  an integer).
+	* user_details.php3: optimized the 'check_rights()' function.
 
 2001-08-28  Loïc Chapeaux  <lolo@phpheaven.net>
 	* lang/galician.inc.php3, select_lang.inc.php3: new Galician lang thanks to
diff --git a/user_details.php3 b/user_details.php3
index 1c594fced..a009c78c5 100644
--- a/user_details.php3
+++ b/user_details.php3
@@ -2,8 +2,8 @@
 /* $Id$*/
 
 
-require("./grab_globals.inc.php3");
-require("./lib.inc.php3");
+require('./grab_globals.inc.php3');
+require('./lib.inc.php3');
 
 function check_operations()
 {
@@ -672,15 +672,23 @@ function edit_operations($host, $user)
     <?php
 }
 
+/**
+ * Checks whether the current user is a super-user or not
+ *
+ * @return  boolean  true as soon as the current user is super-user, no return
+ *                   else
+ *
+ * @access	private
+ */
 function check_rights()
 {
-    global $strNoRights;
-
-    $result = mysql_query("SELECT * FROM mysql.user");
-    $rows = @mysql_num_rows($result);
-
-    if (!isset($rows)) mysql_die($strNoRights);
-}
+    $result = @mysql_query('USE mysql');
+    if (mysql_error()) {
+        mysql_die($GLOBALS['strNoRights']);
+    }
+    
+    return true;
+} // end of the 'check_rights()' function
 
 
 function table_users($host = FALSE, $user = FALSE)
@@ -814,7 +822,7 @@ function confirm() {
 
 if(!isset($message))
 {
-    include("./header.inc.php3");
+    include('./header.inc.php3');
 }
 else
 {
@@ -882,6 +890,6 @@ if (isset($edit) && $edit) { # Edit an user
   normal_operations();
 }
 
-require("./footer.inc.php3");
+require('./footer.inc.php3');
 
 ?>