diff --git a/ChangeLog b/ChangeLog index cb9edcd4b..f7354da74 100755 --- a/ChangeLog +++ b/ChangeLog @@ -20,6 +20,11 @@ $Source$ header_printview.inc.php, left.php, querywindow.php, transformation_wrapper.php, left_header.inc.php: removed queryframe.php and references to it + * index.php, footer.inc.php, left.php, querywindow.php, server_databases.php + libraries/common.lib.php, libraries/left_header.inc.php, + libraries/sql_query_form.lib.php, libraries/querywindow.js: + code cleanup whole querywindow js stuff, moved all in one new js file, + now included in index.php, bug #1327055 2005-10-16 Michal Čihař * db_details_links.php: Disable drop tab on mysql database (RFE #1327514). diff --git a/footer.inc.php b/footer.inc.php index 1ce21ad49..223e528eb 100644 --- a/footer.inc.php +++ b/footer.inc.php @@ -14,90 +14,53 @@ require_once('./libraries/relation.lib.php'); // for PMA_setHistory() */ // If query window is wanted and open, update with latest selected db/table. -if ($cfg['QueryFrame'] && $cfg['QueryFrameJS']) { +if ( $cfg['QueryFrame'] && $cfg['QueryFrameJS'] ) { ?> - + phpMyAdmin - + + + + name="nav" + id="framenavigation" /> diff --git a/left.php b/left.php index 905a696be..6136dc35e 100644 --- a/left.php +++ b/left.php @@ -78,73 +78,10 @@ echo ""; content="text/html; charset=" /> - + - @@ -235,10 +144,10 @@ if ( $num_dbs === 0 ) {
@@ -401,7 +310,7 @@ function PMA_displayDbList( $ext_dblist ) { ?> () @@ -507,8 +416,8 @@ function PMA_displayTableList( $tables, $visible = false, target="_parent" onclick=" if ( ! toggle('', true) ) - goTo( './left.php?' ); - goTo( './' ); + window.parent.goTo( './', 'main' ); return false;"> diff --git a/libraries/common.lib.php b/libraries/common.lib.php index d5e700aef..e23af89b6 100644 --- a/libraries/common.lib.php +++ b/libraries/common.lib.php @@ -863,7 +863,7 @@ function PMA_getDbList() { function PMA_getHtmlSelectDb( $selected = '' ) { $dblist = PMA_getDbList(); $return = ''; $input_query_history[] = ''; - $sql_history[] = '
  • ' - . '' . $titles['Change'] . '' - . ' [' . htmlspecialchars($query_history_latest_db) . '] ' . urldecode($query_history_latest) . '' - . '
  • ' . "\n"; + $sql_history[] = + '
  • ' + .'' . $titles['Change'] . '' + .' [' . htmlspecialchars($query_history_latest_db) . '] ' . urldecode($query_history_latest) . '' + .'
  • ' . "\n"; $sql_query = urldecode($query_history_latest); $db = $query_history_latest_db; $table = $query_history_latest_table; $dup_sql[$query_history_latest] = true; - } elseif (isset($query_history_latest) && $query_history_latest != '') { + } elseif ( ! empty( $query_history_latest ) ) { $sql_query = urldecode($query_history_latest); } @@ -200,8 +220,8 @@ if ($cfg['QueryFrame'] && $cfg['QueryFrameJS']) { foreach ($temp_history AS $history_nr => $history_array) { if (!isset($dup_sql[$history_array['sqlquery']])) { $sql_history[] = '
  • ' - . '' . $titles['Change'] . '' - . '[' . htmlspecialchars($history_array['db']) . '] ' . urldecode($history_array['sqlquery']) . '' + . '' . $titles['Change'] . '' + . '[' . htmlspecialchars($history_array['db']) . '] ' . urldecode($history_array['sqlquery']) . '' . '
  • ' . "\n"; $dup_sql[$history_array['sqlquery']] = true; } @@ -220,8 +240,8 @@ if ($cfg['QueryFrame'] && $cfg['QueryFrameJS']) { $input_query_history[] = ''; $sql_history[] = '
  • ' - . '' . $titles['Change'] . '' - . '[' . htmlspecialchars($query_history_db[$query_no]) . '] ' . urldecode($query_sql) . '' + . '' . $titles['Change'] . '' + . '[' . htmlspecialchars($query_history_db[$query_no]) . '] ' . urldecode($query_sql) . '' . '
  • ' . "\n"; $dup_sql[$query_sql] = true; } // end if check if this item exists @@ -282,7 +302,7 @@ if ($cfg['QueryFrame'] && $cfg['QueryFrameJS']) { - + 0) { diff --git a/server_databases.php b/server_databases.php index 4055affc2..e6e4abe01 100644 --- a/server_databases.php +++ b/server_databases.php @@ -230,7 +230,7 @@ if (count($statistics) > 0) { echo ' ' . "\n"; } echo ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . htmlspecialchars($current['db_name']) . "\n" . ' ' . "\n" . ' ' . "\n"; @@ -252,7 +252,7 @@ if (count($statistics) > 0) { } if ($is_superuser) { echo ' ' . "\n" - . ' '. "\n" + . ' '. "\n" . ' ' .($cfg['PropertiesIconic'] ? ' ' .$strCheckPrivs . ' ' : $strCheckPrivs ). "\n" . ' ' . "\n" . ' ' . "\n";