[security] Fixed possible session manipulation in swekey authentication, see PMASA-2011-12

This commit is contained in:
Herman van Rink
2011-07-09 23:10:23 +02:00
parent 3ae58f0cd6
commit e7bb42c002
2 changed files with 5 additions and 2 deletions

View File

@@ -5,6 +5,7 @@ phpMyAdmin - ChangeLog
- [security] Fixed XSS vulnerability, see PMASA-2011-9 - [security] Fixed XSS vulnerability, see PMASA-2011-9
- [security] Fixed local file inclusion vulnerability, see PMASA-2011-10 - [security] Fixed local file inclusion vulnerability, see PMASA-2011-10
- [security] Fixed local file inclusion vulnerability and code execution, see PMASA-2011-11 - [security] Fixed local file inclusion vulnerability and code execution, see PMASA-2011-11
- [security] Fixed possible session manipulation in swekey authentication, see PMASA-2011-12
3.4.3.1 (2011-07-02) 3.4.3.1 (2011-07-02)
- [security] Fixed possible session manipulation in swekey authentication, see PMASA-2011-5 - [security] Fixed possible session manipulation in swekey authentication, see PMASA-2011-5

View File

@@ -143,7 +143,9 @@ function Swekey_auth_error()
return "Internal Error: CA File $caFile not found"; return "Internal Error: CA File $caFile not found";
$result = null; $result = null;
parse_str($_SERVER['QUERY_STRING']); $swekey_id = $_GET['swekey_id'];
$swekey_otp = $_GET['swekey_otp'];
if (isset($swekey_id)) { if (isset($swekey_id)) {
unset($_SESSION['SWEKEY']['AUTHENTICATED_SWEKEY']); unset($_SESSION['SWEKEY']['AUTHENTICATED_SWEKEY']);
if (! isset($_SESSION['SWEKEY']['RND_TOKEN'])) { if (! isset($_SESSION['SWEKEY']['RND_TOKEN'])) {
@@ -166,7 +168,7 @@ function Swekey_auth_error()
$result = __('No valid authentication key plugged'); $result = __('No valid authentication key plugged');
if ($_SESSION['SWEKEY']['CONF_DEBUG']) if ($_SESSION['SWEKEY']['CONF_DEBUG'])
{ {
$result .= "<br>".$swekey_id; $result .= "<br>" . htmlspecialchars($swekey_id);
} }
unset($_SESSION['SWEKEY']['CONF_LOADED']); // reload the conf file unset($_SESSION['SWEKEY']['CONF_LOADED']); // reload the conf file
} }