nettika/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unneeded code; XHTML compliancy; XSS protection

Browse Source
This commit is contained in:
Marc Delisle
2009-11-29 12:50:21 +00:00
parent 71e6f68763
commit f2b4d0ec51
1 changed files with 9 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
db_tracking.php
View File

@@ -42,10 +42,6 @@ if ($num_tables == 0 && count($data['ddlog']) == 0) {
* Display top menu links * Display top menu links
*/ */
require_once './libraries/db_links.inc.php'; require_once './libraries/db_links.inc.php';
?>
<p/>
<p/>
<?php
/* /*
* List versions of current table * List versions of current table
@@ -99,24 +95,18 @@ if ($last_version > 0) {
} else { } else {
$version_status = $strTrackingStatusNotActive; $version_status = $strTrackingStatusNotActive;
} }
$tmp_link = 'tbl_tracking.php?' . $url_query . '&amp;table=' . htmlspecialchars($version['table_name']);
if (($version['version'] == $last_version) && ($version_status == $strTrackingStatusNotActive)) {
$tracking_active = false;
}
if (($version['version'] == $last_version) && ($version_status == $strTrackingStatusActive)) {
$tracking_active = true;
}
?> ?>
<tr class="<?php echo $style;?>"> <tr class="<?php echo $style;?>">
<td><?php echo $version['db_name'];?></td> <td><?php echo htmlspecialchars($version['db_name']);?></td>
<td><?php echo $version['table_name'];?></td> <td><?php echo htmlspecialchars($version['table_name']);?></td>
<td><?php echo $version['version'];?></td> <td><?php echo $version['version'];?></td>
<td><?php echo $version['date_created'];?></td> <td><?php echo $version['date_created'];?></td>
<td><?php echo $version['date_updated'];?></td> <td><?php echo $version['date_updated'];?></td>
<td><?php echo $version_status;?></td> <td><?php echo $version_status;?></td>
<td> <a href="tbl_tracking.php?<?php echo $url_query;?>&table=<?php echo $version['table_name'];?>"><?php echo $strTrackingVersions;?></a> <td> <a href="<?php echo $tmp_link; ?>"><?php echo $strTrackingVersions;?></a>
| <a href="tbl_tracking.php?<?php echo $url_query;?>&table=<?php echo $version['table_name'];?>&report=true&version=<?php echo $version['version'];?>"><?php echo $strTrackingReport;?></a> | <a href="<?php echo $tmp_link; ?>&amp;report=true&amp;version=<?php echo $version['version'];?>"><?php echo $strTrackingReport;?></a>
| <a href="tbl_tracking.php?<?php echo $url_query;?>&table=<?php echo $version['table_name'];?>&snapshot=true&version=<?php echo $version['version'];?>"><?php echo $strTrackingStructureSnapshot;?></a></td> | <a href="<?php echo $tmp_link; ?>&amp;snapshot=true&amp;version=<?php echo $version['version'];?>"><?php echo $strTrackingStructureSnapshot;?></a></td>
</tr> </tr>
<?php <?php
if ($style == 'even') { if ($style == 'even') {
@@ -125,6 +115,7 @@ if ($last_version > 0) {
$style = 'even'; $style = 'even';
} }
} }
unset($tmp_link);
?> ?>
</tbody> </tbody>
</table> </table>
@@ -161,7 +152,7 @@ if (isset($my_tables)) {
foreach ($my_tables as $key => $tablename) { foreach ($my_tables as $key => $tablename) {
if (PMA_Tracker::getVersion($GLOBALS['db'], $tablename) == -1) { if (PMA_Tracker::getVersion($GLOBALS['db'], $tablename) == -1) {
$my_link = '<a href="tbl_tracking.php?' . $url_query . '&table=' . $tablename .'">'; $my_link = '<a href="tbl_tracking.php?' . $url_query . '&amp;table=' . htmlspecialchars($tablename) .'">';
if ($cfg['PropertiesIconic']) { if ($cfg['PropertiesIconic']) {
$my_link .= '<img class="icon" src="' . $pmaThemeImage . 'eye.png" width="16" height="16" alt="' . $strTrackingTrackTable . '" /> '; $my_link .= '<img class="icon" src="' . $pmaThemeImage . 'eye.png" width="16" height="16" alt="' . $strTrackingTrackTable . '" /> ';
@@ -169,7 +160,7 @@ if (isset($my_tables)) {
$my_link .= $strTrackingTrackTable . '</a>'; $my_link .= $strTrackingTrackTable . '</a>';
?> ?>
<tr class="<?php echo $style;?>"> <tr class="<?php echo $style;?>">
<td><?php echo $tablename;?></td> <td><?php echo htmlspecialchars($tablename);?></td>
<td><?php echo $my_link;?></td> <td><?php echo $my_link;?></td>
</tr> </tr>
<?php <?php
@@ -186,10 +177,6 @@ if (isset($my_tables)) {
<?php <?php
} }
?>
<p/>
<?php
// If available print out database log // If available print out database log
if (count($data['ddlog']) > 0) { if (count($data['ddlog']) > 0) {
$log = ''; $log = '';