From f47e0933c3263abc7840c59bfa04bbbde6e730c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= Date: Thu, 16 Sep 2010 15:19:46 +0200 Subject: [PATCH] [core] Force generating of new session on login This improves security because session ID and token are generated fresh for each user. --- ChangeLog | 1 + libraries/common.inc.php | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index f31420ae0..a11c8294c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -112,6 +112,7 @@ - bug #3042665 [parser] Add workaround for MySQL way of handling backtick. - bug #3056610 [interface] Removed modification options for information_schema + patch #3055886 [config] Add Left frame table filter visibility config option, thanks to eesau +- [core] Force generating of new session on login 3.3.8.0 (not yet released) - bug #3059311 [import] BIGINT field type added to table analysis diff --git a/libraries/common.inc.php b/libraries/common.inc.php index b01a6ee2f..ee2014582 100644 --- a/libraries/common.inc.php +++ b/libraries/common.inc.php @@ -814,6 +814,8 @@ if (! defined('PMA_MINIMUM_COMMON')) { */ require_once './libraries/auth/' . $cfg['Server']['auth_type'] . '.auth.lib.php'; if (!PMA_auth_check()) { + /* Force generating of new session on login */ + PMA_secureSession(); PMA_auth(); } else { PMA_auth_set_user(); @@ -975,7 +977,7 @@ PMA_Tracker::enable(); * @global boolean $GLOBALS['is_ajax_request'] * @todo should this be moved to the variables init section above? * - * Check if the current request is an AJAX request, and set is_ajax_request + * Check if the current request is an AJAX request, and set is_ajax_request * accordingly. Suppress headers, footers and unnecessary output if set to * true */