diff --git a/ChangeLog b/ChangeLog index 827992e94..8f3db452b 100755 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,12 @@ phpMyAdmin - Changelog $Id$ $Source$ +2006-01-04 Marc Delisle + * server_privileges.php: since we use DROP USER, some options to + remove a user did not work under MySQL 4.1.x (only mode 2 worked), + so I remove them from the dialog. Thanks to Ken Stanley for + the bug report. + 2006-01-02 Marc Delisle * libraries/display_create_table.lib.php: bug #1389868, Safari's rendering of "Create table" fieldset, thanks to Ryan Schmidt diff --git a/server_privileges.php b/server_privileges.php index cc5818ab1..0315529da 100644 --- a/server_privileges.php +++ b/server_privileges.php @@ -1486,8 +1486,14 @@ if ( empty( $adduser ) && empty( $checkprivs ) ) { . ' ' . "\n" . ($GLOBALS['cfg']['PropertiesIconic'] ? ' ' . "\n" : '' ) . ' ' . $GLOBALS['strRemoveSelectedUsers'] . '' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n"; + + // before MySQL 4.1.1, we offer some choices for the delete + // mode, but for 4.1.1+, it will be done with REVOKEing the + // privileges then a DROP USER (even no REVOKE at all + // for MySQL 5), so no need to offer so many options + if (PMA_MYSQL_INT_VERSION < 40101) { + echo ' ' . "\n" . '
' . "\n" @@ -1498,8 +1504,13 @@ if ( empty( $adduser ) && empty( $checkprivs ) ) { . ' ' . "\n" . '
' . "\n" - . ' ' . "\n" + . '
' . "\n"; + } else { + echo ' ' . "\n" + . '( ' . $GLOBALS['strRevokeAndDelete'] . ' )
' . "\n"; + } + + echo ' ' . "\n" . ' ' . "\n"