common.lib.php should REALLY REALLY and ALWAYS be the first include

ChangeLog

@@ -17,6 +17,8 @@ $Source$
     * lang/english-*: small improvements
     * tbl_properties_structure.php
       - do not truncate rowcount and next autoindex
+    * /*
+      - common.lib.php should REALLY REALLY and ALWAYS be the first include
 
 2005-11-17 Marc Delisle  <lem9@users.sourceforge.net>
     * Documentation.html: patch #1353283, thanks to Isaac Bennetch

calendar.php

@@ -1,7 +1,6 @@
 <?php
 /* $Id$ */
 
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/header_http.inc.php');
 $page_title = $strCalendar;

chk_rel.php

@@ -6,7 +6,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./db_details_common.php');
 require_once('./libraries/relation.lib.php');

db_create.php

@@ -6,10 +6,9 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
+require_once('./libraries/common.lib.php');
 $js_to_run = 'functions.js';
 require_once('./header.inc.php');
-require_once('./libraries/common.lib.php');
 require_once('./libraries/mysql_charsets.lib.php');
 
 

db_datadict.php

@@ -5,8 +5,9 @@
 /**
  * Gets the variables sent or posted to this script, then displays headers
  */
+require_once('./libraries/common.lib.php');
+
 if (!isset($selected_tbl)) {
-    require_once('./libraries/grab_globals.lib.php');
     require_once('./header.inc.php');
 }
 

db_details.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Runs common work

db_details_export.php

@@ -13,6 +13,8 @@
 /**
  * Gets some core libraries
  */
+require_once('./libraries/common.lib.php');
+
 $sub_part  = '_export';
 require_once('./db_details_common.php');
 $url_query .= '&goto=db_details_export.php';

db_details_importdocsql.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * This script imports relation infos from docSQL (www.databay.de)
@@ -13,13 +14,8 @@
  * the headers
  */
 require_once('./libraries/read_dump.lib.php');
-require_once('./libraries/grab_globals.lib.php');
 require_once('./header.inc.php');
 
-//require common added for string importing - Robbat2, 15 January 2003 9.34PM
-//all hardcoded strings converted by Robbat2, 15 January 2003 9.34PM
-require_once('./libraries/common.lib.php');
-
 // Check parameters
 PMA_checkParameters(array('db'));
 

db_details_links.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * If coming from a Show MySQL link on the home page,

db_details_qbe.php

@@ -2,12 +2,10 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
-
 /**
  * Get the values of the variables posted or sent to this script and display
  * the headers
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/relation.lib.php');
 

db_import.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Gets tables informations and displays top links

db_operations.php

@@ -2,7 +2,6 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/mysql_charsets.lib.php');
 /**

db_printview.php

@@ -2,16 +2,14 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Gets the variables sent or posted to this script, then displays headers
  */
-require_once('./libraries/grab_globals.lib.php');
 $print_view = TRUE;
 require_once('./header.inc.php');
 
-// Check parameters
-require_once('./libraries/common.lib.php');
 
 PMA_checkParameters(array('db'));
 

db_search.php

@@ -5,6 +5,7 @@
  * Credits for this script goes to Thomas Chaumeny <chaume92 at aol.com>
  */
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Gets some core libraries and send headers

export.php

@@ -5,7 +5,6 @@
 /**
  * Get the variables sent or posted to this script and a core script
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/zip.lib.php');
 

header.inc.php

@@ -2,6 +2,8 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
+
 if (empty($GLOBALS['is_header_sent'])) {
 
     /**

import.php

@@ -7,9 +7,8 @@
 /**
  * Get the variables sent or posted to this script and a core script
  */
-require_once('./libraries/grab_globals.lib.php');
-$js_to_run = 'functions.js';
 require_once('./libraries/common.lib.php');
+$js_to_run = 'functions.js';
 
 // Are we just executing plain query or sql file? (eg. non import, but query box/window run)
 if (!empty($sql_query)) {

index.php

@@ -38,7 +38,6 @@
 /**
  * Gets core libraries and defines some variables
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 /**
  * Includes the ThemeManager if it hasn't been included yet

pdf_pages.php

@@ -5,7 +5,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./db_details_common.php');
 

pdf_schema.php

@@ -10,7 +10,6 @@
 /**
  * Gets some core scripts
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 
 

phpinfo.php

@@ -6,7 +6,6 @@
 /**
  * Gets core libraries and defines some variables
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 
 

querywindow.php

@@ -2,12 +2,12 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Gets the variables sent to this script, retains the db name that may have
  * been defined as startup option and include a core library
  */
-require_once('./libraries/grab_globals.lib.php');
 if (!empty($db)) {
     $db_start = $db;
 }
@@ -16,7 +16,6 @@ if (!empty($db)) {
 /**
  * Gets a core script and starts output buffering work
  */
-require_once('./libraries/common.lib.php');
 require_once './libraries/sql_query_form.lib.php';
 require_once('./libraries/ob.lib.php');
 if ( $GLOBALS['cfg']['OBGzip'] ) {

server_binlog.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Does the common work

server_collations.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Does the common work

server_common.inc.php

@@ -5,7 +5,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 
 /**

server_engines.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Does the common work

server_export.php

@@ -2,19 +2,12 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
-
-/**
- * Checks if the left frame has to be reloaded
- */
-require_once('./libraries/grab_globals.lib.php');
-
-
 /**
  * Does the common work
  */
-$js_to_run = 'functions.js';
+require_once('./libraries/common.lib.php');
-require('./server_common.inc.php');
 
+$js_to_run = 'functions.js';
 
 /**
  * Displays the links

server_import.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Does the common work

server_privileges.php

@@ -2,6 +2,8 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
+
 /**
  * Does the common work
  */

server_processlist.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Does the common work

server_sql.php

@@ -2,10 +2,12 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Does the common work
  */
+$js_to_run = 'functions.js';
 require_once './server_common.inc.php';
 require_once './libraries/sql_query_form.lib.php';
 

server_status.php

@@ -6,6 +6,8 @@
  *  + reset status vriales
  */
 
+require_once('./libraries/common.lib.php');
+
 /**
  * Does the common work
  */

server_variables.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Does the common work

tbl_addfield.php

@@ -5,7 +5,8 @@
 /**
  * Get some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
+require_once('./libraries/common.lib.php');
+
 $js_to_run = 'functions.js';
 require_once('./header.inc.php');
 

tbl_alter.php

@@ -5,7 +5,8 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
+require_once('./libraries/common.lib.php');
+
 $js_to_run = 'functions.js';
 require_once('./header.inc.php');
 

tbl_change.php

@@ -5,7 +5,8 @@
 /**
  * Get the variables sent or posted to this script and displays the header
  */
-require_once('./libraries/grab_globals.lib.php');
+require_once('./libraries/common.lib.php');
+
 $js_to_run = 'tbl_change.js';
 require_once('./header.inc.php');
 require_once('./libraries/relation.lib.php'); // foreign keys

tbl_create.php

@@ -5,11 +5,10 @@
 /**
  * Get some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
-$js_to_run = 'functions.js';
-
 require_once('./libraries/common.lib.php');
 
+$js_to_run = 'functions.js';
+
 if (isset($table)) {
     $table = PMA_sanitize($table);
 }

tbl_import.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Gets tables informations and displays top links

tbl_indexes.php

@@ -5,7 +5,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/tbl_indexes.lib.php');
 

tbl_move_copy.php

@@ -5,7 +5,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 
 // Check parameters

tbl_printview.php

@@ -1,13 +1,13 @@
 <?php
 /* $Id$ */
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Gets the variables sent or posted to this script, then displays headers
  */
 $print_view = TRUE;
 if (!isset($selected_tbl)) {
-    require_once('./libraries/grab_globals.lib.php');
     require_once('./header.inc.php');
 }
 

tbl_properties.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Runs common work

tbl_properties_export.php

@@ -2,6 +2,7 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
 
 /**
  * Gets tables informations and displays top links

tbl_properties_operations.php

@@ -2,6 +2,8 @@
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
 
+require_once('./libraries/common.lib.php');
+
 /**
  * Runs common work
  */

tbl_query_box.php

@@ -10,7 +10,6 @@
  */
 
 // Check parameters
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/bookmark.lib.php');
 require_once './libraries/sql_query_form.lib.php';

tbl_rename.php

@@ -6,10 +6,9 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
-$js_to_run = 'functions.js';
 require_once('./libraries/common.lib.php');
 
+$js_to_run = 'functions.js';
 PMA_checkParameters(array('db','table'));
 
 /**

tbl_replace.php

@@ -5,7 +5,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 
 // Check parameters

tbl_row_action.php

@@ -1,7 +1,6 @@
 <?php
 /* $Id$ */
 // vim: expandtab sw=4 ts=4 sts=4:
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/mysql_charsets.lib.php');
 

tbl_select.php

@@ -6,7 +6,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 require_once('./libraries/relation.lib.php'); // foreign keys
 require_once('./libraries/mysql_charsets.lib.php');

themes.php

@@ -1,6 +1,5 @@
 <?php
 /* get some globals */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 
 /* Theme Select */

transformation_wrapper.php

@@ -4,11 +4,6 @@
 
 define('IS_TRANSFORMATION_WRAPPER', true);
 
-/**
- * Get the variables sent or posted to this script and displays the header
- */
-require_once('./libraries/grab_globals.lib.php');
-
 /**
  * Gets a core script and starts output buffering work
  */

user_password.php

@@ -6,7 +6,6 @@
 /**
  * Gets some core libraries
  */
-require_once('./libraries/grab_globals.lib.php');
 require_once('./libraries/common.lib.php');
 
 /**