Commit Graph

46 Commits

Author SHA1 Message Date
Marc Delisle
39725e9dfb bug #1982489 [relation] Relationship view should check for changes 2008-07-04 14:36:18 +00:00
Marc Delisle
609d38a9cd start QA_11 2007-07-18 15:55:11 +00:00
Marc Delisle
e2599e32c5 start QA_2_11 2007-07-18 15:54:09 +00:00
Sebastian Mendel
cfeb306526 coding standard: no spaces inside braces 2007-04-01 11:02:46 +00:00
Sebastian Mendel
adb39168cc coding standard: no braces around include 2007-04-01 09:51:41 +00:00
Sebastian Mendel
b2f3ae5fcf make $sql_query persistent (init it, never unset it, always assume it is set) 2007-04-01 09:26:14 +00:00
Sebastian Mendel
d0facc3d4f splitted common.lib.php into common.inc.php, core.lib.php and common.lib.php 2007-03-20 14:16:18 +00:00
Sebastian Mendel
374abd5173 fixed/added page level docblock 2007-03-20 10:32:13 +00:00
Sebastian Mendel
817e790762 synced/fixed vim line 2007-03-19 17:55:39 +00:00
Marc Delisle
8e61869a17 RFE #1621025, show SQL statements in Relation View 2006-12-29 16:27:25 +00:00
Marc Delisle
6a4bb0d2da bug #1597019, wrong error message when foreign key is not the same data type as referenced key 2006-11-19 18:39:54 +00:00
Michal Čihař
ad06b4a991 Rename tbl_* files to drop useless _properties part. 2006-10-25 10:55:20 +00:00
Marc Delisle
1060b0fa14 trap error 1452 when adding a foreign key and the constraint fails 2006-10-01 18:11:44 +00:00
Sebastian Mendel
3787870356 fixed bug #1459418 Add foreign key fail on column with ' in name 2006-04-11 17:50:49 +00:00
Sebastian Mendel
0ae8842353 (not complete) PEAR coding standard 2006-01-17 17:03:02 +00:00
Sebastian Mendel
16a71a194e added database name to relation querys 2005-12-17 17:36:58 +00:00
Sebastian Mendel
8344198c10 moved tbl_properties_common.php into libraries 2005-12-08 13:19:25 +00:00
Michal Čihař
6aeabf44d1 Move footer.inc.php, header.inc.php and header_printview.inc.php to libraries folder as it does not require direct access. 2005-11-24 09:12:17 +00:00
Michal Čihař
c40b663969 Move tbl_properties{.inc,_links,_table_info}.php to libraries folder as it does not require direct access. 2005-11-24 08:55:33 +00:00
Sebastian Mendel
0567bfe215 drop PMA_setFontSizes() 2005-11-23 14:17:53 +00:00
Sebastian Mendel
7a4a72e955 - fixed html output of table
- used fieldset for forms
2005-11-02 14:35:26 +00:00
Michal Čihař
3649d901ec Use more require_once to avoid acquiring table info several times. 2005-10-08 18:14:09 +00:00
Michal Čihař
64bd56dfba Support for browsing selected columns (RFE #1275909). 2005-09-26 19:03:11 +00:00
Marc Delisle
6950dc7100 bug #1227710, unsaved relations lost when changing field to display 2005-07-11 17:55:41 +00:00
Marc Delisle
d051012652 remove comments handling from relation view 2005-02-05 20:17:04 +00:00
Michal Čihař
f1f39b8ed1 added infou about UFPDF to documentation 2004-12-29 14:16:51 +00:00
Marc Delisle
141e44f6a7 bug #1050424 2004-10-30 00:52:55 +00:00
Michal Čihař
3f258cfb45 Cleanup of message displaying and navigation reloading. 2004-10-21 10:18:12 +00:00
Michal Čihař
b4151eeda8 Backquote table name (bug #1050441). 2004-10-20 12:24:47 +00:00
Marc Delisle
a16d97912f bug 1016997 wrong db name in SHOW KEYS 2004-08-27 17:20:19 +00:00
Marc Delisle
a4998f52d2 bug 978111 relation view out of sync error 2004-07-14 14:31:33 +00:00
Marc Delisle
ce969cb209 use PMA_DBI_try_query to catch the error 2004-07-07 17:02:53 +00:00
Marc Delisle
1142f3cbed enable Relation view for InnoDB even if the internal infrastructure is not available 2004-06-17 11:13:14 +00:00
Marc Delisle
d9a21610d1 redesign part 3 2004-06-13 21:39:08 +00:00
Michal Čihař
1aaa89fa54 Little code reorganistaion (RFE #957308), removed some remaining php3 compatibility code in SQL parser. 2004-05-20 16:14:13 +00:00
Marcel Tschopp
4e62f7658f Changed some queries to use MYSQLI_STORE_RESULT.
phpMyAdmin now works with MYSQLI_USE_RESULT as default.
2004-04-10 16:19:21 +00:00
Marcel Tschopp
74cc95fe29 phpMyAdmin should now be fully compatible with the new mysqli extension. 2004-04-08 12:30:40 +00:00
Garvin Hicking
b8df10e41e Get rid of mysql_data_seek(). Use pre-cached PHP array for mysqli
compatibility and bandwidth saving.

Memory issues by caching should not arise, as the used cache will (in our
previously used cases) only cache index fields and max. 200 relation rows.

I tested performance on my machine: By fetching 400kb of data twice via
mysql_fetch_row() -> mysql_data_seek() -> mysql_fetch_row() this was
performed in 0.25 seconds. By fetching it once and caching in a PHP array
via mysql_fetch_row -> foreach this is performed in 0.32 seconds.

With usual data as used in PMA (10kb) I could only detect a performance
change of 0.009 seconds, which is respectable I think.

By not using mysql_data_seek we are later able to use global mysqli
USE_RESULT options to fetch rows singly. I discussed that yesterday with
Rabus, and if there are any objections we can surely discuss that further on
the list.
2004-01-28 11:23:38 +00:00
Alexander M. Turek
2915b5c3ce Added MySQLi library; Removed calls to old mysql_wrappers library. 2004-01-22 02:13:48 +00:00
Marc Delisle
28a5d0476e PMA_DBI_num_rows 2004-01-20 19:35:37 +00:00
Marc Delisle
a58afea58a bug 860258 2003-12-18 20:59:04 +00:00
Alexander M. Turek
37d50c1822 Huge set of optimizations, please test! 2003-11-26 22:52:25 +00:00
Garvin Hicking
8d1bfe6f3b Reverted some obfuscated RegExes. Nijel, as you where working on that: I removed the bugfixes you threw in for my faulty code because there where some issue left (for me):
The lines

$re0 = '@(^|(\\\\\\\\)+|[^\\\\])'; // non-escaped wildcards
$re1 = '@(^|[^\])(\\\)+'; // escaped wildcards

as they currently where made no sense to me, because the single [^\] should be replaced to [^\\\\] as well, doesn't it? To not seriously break more stuff I decided to revert to the previous mechanism here.

I will do more serious tests the next days and will actually work with my PMA again and I pay close attention to see if there are any issues left.

I also searched through the code to see if the setting of the array points from former while() constructs was in any way used [current(), next(), prev(), key(), end(), each()] but did find none.
2003-11-25 19:20:20 +00:00
Garvin Hicking
c2b46ac945 Final batch of PHP3-Compatibility fixes. Please test. :-) 2003-11-22 20:57:48 +00:00
Marc Delisle
24af1f2962 strUpgradeMySQL -> strUpgrade 2003-11-18 16:09:03 +00:00
Michal Čihař
6884f9701a no more support for php3 2003-11-18 15:20:45 +00:00