Commit Graph

57 Commits

Author SHA1 Message Date
Michal Čihař
fb9a3a598e Check before commit! 2006-11-17 08:49:30 +00:00
Marc Delisle
d5d8aef10f bug #1437754, search combos default to key zero 2006-02-24 20:31:45 +00:00
Sebastian Mendel
ac9d8b21a3 check if $cfg['Server']['pmadb'] really exists and is selectable, minor tweaks and formating 2006-02-21 15:31:37 +00:00
Sebastian Mendel
cd340d8496 moved PMA_generateFieldSpec(), PMA_tableIsView(), PMA_countRecords(), PMA_generateAlterTable() into class PMA_Table 2006-02-21 11:07:46 +00:00
Sebastian Mendel
0ae8842353 (not complete) PEAR coding standard 2006-01-17 17:03:02 +00:00
Sebastian Mendel
7358f5a712 allow 0 as name for database, table collumn, alias and index 2006-01-14 23:17:17 +00:00
Sebastian Mendel
16a71a194e added database name to relation querys 2005-12-17 17:36:58 +00:00
Sebastian Mendel
5b9cab5a91 check magic_quotes only once in common.inc.php 2005-12-12 14:28:28 +00:00
Marc Delisle
9cc77d6ecb bug #1370785, error browsing a table under PHP 4 when no controluser is defined but a pmadb is defined 2005-12-10 15:51:38 +00:00
Sebastian Mendel
b755b20bde uninitialized variable 2005-11-23 17:34:44 +00:00
Marc Delisle
3885bb6bd7 dbh becomes controllink 2005-11-20 14:00:49 +00:00
Marc Delisle
6f7d44b596 already a function to do the job 2005-10-23 12:15:15 +00:00
Marc Delisle
4373f1ae3c sort id-content by id and content-id by content 2005-10-21 20:06:32 +00:00
Michal Čihař
b654a24543 Do not set database if not needed. 2005-10-18 14:53:36 +00:00
Michal Čihař
a841d13500 Do not try to restore database as control user, it has to fail. 2005-10-08 18:27:48 +00:00
Michal Čihař
96722c24f4 fix undefined variable warning 2005-10-08 17:53:31 +00:00
Michal Čihař
ae6aa68843 Fix reading native MySQL comments when no phpMyAdmin one defined (bug #1312758). 2005-10-08 17:41:23 +00:00
Michal Čihař
c62f975a47 Use common code for CREATE/ALTER TABLE, set comments on creating table, so that user can see it in the query. 2005-10-08 17:28:31 +00:00
Marc Delisle
171613c0d0 bug #1262250, cannot change ENUM default value to empty 2005-09-28 11:50:50 +00:00
Marc Delisle
8f9b686e20 for the new ForeignKeyDropdownOrder, id and content were reversed (id-content showed content then id) 2005-07-22 18:01:37 +00:00
Robin Johnson
131866b448 Support for customizing foreign-key dropdown, take #2, now very customizable,
incl max item limit.
2005-06-23 14:16:33 +00:00
Robin Johnson
3576fd016a Allow selection of drop-down order. 2005-06-22 16:45:17 +00:00
Marc Delisle
8ddcb6d302 create table and TIMESTAMP options 2005-03-31 21:54:36 +00:00
Marc Delisle
c021e6b464 bug #1170549 Adding fields NOT NULL under MySQl 4.1 2005-03-28 01:22:45 +00:00
Alexander M. Turek
456a26f636 information_schema relations 2005-03-27 23:26:00 +00:00
Alexander M. Turek
96fff6fe00 Removed recoding function calls from controluser queries as they do not depend on the connection charset anymore. 2005-03-25 14:05:24 +00:00
Alexander M. Turek
a4a372597d bug #1159415 2005-03-10 21:40:44 +00:00
Marc Delisle
c84507f8d9 problem with getting comments when creating a new table under MySQL 4.1.x with extension mysql 2005-03-10 19:49:09 +00:00
Marc Delisle
41ae394e2e bug #1159415, data dictionary broken 2005-03-09 16:06:10 +00:00
Marc Delisle
287af827e5 bug 1157972, db comments broken 2005-03-07 14:56:26 +00:00
Marc Delisle
e430651d24 native comments 2005-03-06 12:33:19 +00:00
Marc Delisle
9bef31439e native comments 2005-03-05 23:21:25 +00:00
Alexander M. Turek
fa8541025e Code redundancy 2005-01-11 21:11:23 +00:00
Michal Čihař
fbd56678f8 CONVERT is for MySQL >= 4.1 and not for MySQL >= 4.0. 2004-08-16 15:19:15 +00:00
Michal Čihař
422bf9d741 Fix typo. 2004-08-16 15:14:16 +00:00
Alexander M. Turek
1f89127a2a bug #995359 2004-08-16 14:31:31 +00:00
Marc Delisle
c469625d0b natural order sort if possible 2004-08-08 18:20:47 +00:00
Marc Delisle
160e4e29bc bugs 1005414 and 1004546 2004-08-08 11:21:05 +00:00
Marc Delisle
b1fe7b3a21 bug 1001159 2004-08-01 16:45:02 +00:00
Alexander M. Turek
e0b4565515 Small optimizations, freed some results 2004-07-31 10:28:47 +00:00
Michal Čihař
9e6c5665c9 Fix possible error on non existant pma db. 2004-06-22 12:46:24 +00:00
Michal Čihař
1aaa89fa54 Little code reorganistaion (RFE #957308), removed some remaining php3 compatibility code in SQL parser. 2004-05-20 16:14:13 +00:00
Marc Delisle
6003e8dd37 bug 930445 when table_info not defined 2004-04-13 12:39:55 +00:00
Marcel Tschopp
031ecca8b7 Changed some queries to use MYSQLI_STORE_RESULT. 2004-04-12 18:34:58 +00:00
Marcel Tschopp
181e1aca82 Use PMA_DBI_fetch_row instead of PMA_DBI_fetch_array in display_tbl.lib.php 2004-04-10 19:04:01 +00:00
Marcel Tschopp
16de478154 Changed some queries to use MYSQLI_STORE_RESULT.
phpMyAdmin now works with MYSQLI_USE_RESULT as default.
2004-04-10 16:27:23 +00:00
Marcel Tschopp
4e62f7658f Changed some queries to use MYSQLI_STORE_RESULT.
phpMyAdmin now works with MYSQLI_USE_RESULT as default.
2004-04-10 16:19:21 +00:00
Marc Delisle
0f6eb412ec bug 877359, constraint and MySQL 3.23.58 2004-03-10 15:57:59 +00:00
Michal Čihař
88dc344cdb Use charset aware substr and strlen functions (bugs #854755 and #910575). 2004-03-09 15:02:28 +00:00
Garvin Hicking
b8df10e41e Get rid of mysql_data_seek(). Use pre-cached PHP array for mysqli
compatibility and bandwidth saving.

Memory issues by caching should not arise, as the used cache will (in our
previously used cases) only cache index fields and max. 200 relation rows.

I tested performance on my machine: By fetching 400kb of data twice via
mysql_fetch_row() -> mysql_data_seek() -> mysql_fetch_row() this was
performed in 0.25 seconds. By fetching it once and caching in a PHP array
via mysql_fetch_row -> foreach this is performed in 0.32 seconds.

With usual data as used in PMA (10kb) I could only detect a performance
change of 0.009 seconds, which is respectable I think.

By not using mysql_data_seek we are later able to use global mysqli
USE_RESULT options to fetch rows singly. I discussed that yesterday with
Rabus, and if there are any objections we can surely discuss that further on
the list.
2004-01-28 11:23:38 +00:00