colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libmm-glib: drop default timeout checks in Command()

Browse Source 
The g_dbus_proxy_get_default_timeout() is by default -1 unless
explicitly updated, so the check doesn't make any sense really. We
didn't see any warning produced because mmcli provides an explicit
timeout of 30s, so it was never the default -1.
This commit is contained in:
Aleksander Morgado
2021-05-18 12:24:39 +02:00
parent a325acd6b1
commit 21ff48ed7d
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libmm-glib/mm-modem.c
View File

@@ -2900,8 +2900,6 @@ mm_modem_command (MMModem *self,
g_return_if_fail (MM_IS_MODEM (self));
if (g_dbus_proxy_get_default_timeout (G_DBUS_PROXY (self)) < timeout)
g_warning ("Requested command timeout is shorter than the default DBus timeout");
mm_gdbus_modem_call_command (MM_GDBUS_MODEM (self), cmd, timeout, cancellable, callback, user_data);
}
@@ -2935,9 +2933,6 @@ mm_modem_command_sync (MMModem *self,
g_return_val_if_fail (MM_IS_MODEM (self), NULL);
if (g_dbus_proxy_get_default_timeout (G_DBUS_PROXY (self)) < timeout)
g_warning ("Requested command timeout is shorter than the default DBus timeout");
if (!mm_gdbus_modem_call_command_sync (MM_GDBUS_MODEM (self), cmd, timeout, &result, cancellable, error))
return NULL;