colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cinterion: remove limitation to IPv4 only PDP contexts

Browse Source 
There was a limitation in the past in the plugin, because one of the steps
during the dial (CONNECT_3GPP_CONTEXT_STEP_PDP_CTX) was to reconfigure a
specific CID hardcoding the IP type to IPv4.

That logic was removed in commit af2d6c1c4b,
but we didn't remove the IPv4 limitation at that point.
This commit is contained in:
Giacinto Cifelli
2020-08-11 14:26:13 +02:00
committed by Aleksander Morgado
parent a36beb0a95
commit 2f684ce92e
2 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/cinterion/mm-broadband-bearer-cinterion.c
View File

@@ -413,7 +413,6 @@ dial_3gpp_context_step (GTask *task)
case DIAL_3GPP_CONTEXT_STEP_FIRST: {
MMBearerIpFamily ip_family;
/* Only IPv4 supported by this bearer implementation for now */
ip_family = mm_bearer_properties_get_ip_type (mm_base_bearer_peek_config (MM_BASE_BEARER (ctx->self)));
if (ip_family == MM_BEARER_IP_FAMILY_NONE || ip_family == MM_BEARER_IP_FAMILY_ANY) {
gchar *ip_family_str;
@@ -424,13 +423,6 @@ dial_3gpp_context_step (GTask *task)
g_free (ip_family_str);
}
if (ip_family != MM_BEARER_IP_FAMILY_IPV4) {
g_task_return_new_error (task, MM_CORE_ERROR, MM_CORE_ERROR_UNSUPPORTED,
"Only IPv4 is supported by this modem");
g_object_unref (task);
return;
}
ctx->step++;
} /* fall through */

7
plugins/cinterion/mm-broadband-modem-cinterion.c
View File

@@ -1174,13 +1174,6 @@ modem_3gpp_set_initial_eps_bearer_settings_step (GTask *task)
if (ip_family == MM_BEARER_IP_FAMILY_NONE || ip_family == MM_BEARER_IP_FAMILY_ANY)
ip_family = MM_BEARER_IP_FAMILY_IPV4;
if (ip_family != MM_BEARER_IP_FAMILY_IPV4) {
/* we must have the same settings as in dial_3gpp_context_step()
* for the case when the CID is re-used for the connection PDN */
mm_obj_dbg (self, "Only IPv4 is supported by this modem");
ip_family = MM_BEARER_IP_FAMILY_IPV4;
}
ip_family_str = mm_3gpp_get_pdp_type_from_ip_family (ip_family);
apn = mm_bearer_properties_get_apn (ctx->properties);
mm_obj_dbg (self, "context CID=%d with APN '%s' and PDP type '%s'", ctx->cid, apn, ip_family_str);