colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fibocom: initial EPS settings update always available in parent

Browse Source 
Assume that the method to change the initial EPS bearer settings is
always implemented in the parent, so that we can avoid the runtime
check.

This also fixes the codepath that would happen if the
iface_modem_3gpp_parent->set_initial_eps_bearer_settings == NULL
condition was valid, as that would end up with a GTask never completed.
This commit is contained in:
Aleksander Morgado
2022-02-16 12:51:25 +01:00
parent d902ddfee5
commit 499cdf79dc
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/fibocom/mm-broadband-modem-mbim-xmm-fibocom.c
View File

@@ -102,14 +102,14 @@ before_attach_apn_modem_power_down_ready (MMIfaceModem *self,
}
mm_obj_dbg (self, "success toggling modem power down before attach APN");
if (iface_modem_3gpp_parent->set_initial_eps_bearer_settings &&
iface_modem_3gpp_parent->set_initial_eps_bearer_settings_finish) {
iface_modem_3gpp_parent->set_initial_eps_bearer_settings (MM_IFACE_MODEM_3GPP (self),
config,
(GAsyncReadyCallback)parent_set_initial_eps_bearer_settings_ready,
task);
return;
}
g_assert (iface_modem_3gpp_parent->set_initial_eps_bearer_settings);
g_assert (iface_modem_3gpp_parent->set_initial_eps_bearer_settings_finish);
iface_modem_3gpp_parent->set_initial_eps_bearer_settings (MM_IFACE_MODEM_3GPP (self),
config,
(GAsyncReadyCallback)parent_set_initial_eps_bearer_settings_ready,
task);
}
static void