colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

telit: fix warnings with -Wimplicit-fallthrough

Browse Source 
telit/mm-broadband-modem-telit.c: In function ‘qss_setup_step’:
  telit/mm-broadband-modem-telit.c:619:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
    619 |             ctx->step++;
        |             ~~~~~~~~~^~
  telit/mm-broadband-modem-telit.c:620:9: note: here
    620 |         case QSS_SETUP_STEP_QUERY:
        |         ^~~~
  telit/mm-broadband-modem-telit.c:653:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
    653 |             ctx->step++;
        |             ~~~~~~~~~^~
  telit/mm-broadband-modem-telit.c:654:9: note: here
    654 |         case QSS_SETUP_STEP_LAST:
        |         ^~~~
  telit/mm-broadband-modem-telit.c: In function ‘load_unlock_retries_step’:
  telit/mm-broadband-modem-telit.c:906:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
    906 |             ctx->step++;
        |             ~~~~~~~~~^~
  telit/mm-broadband-modem-telit.c:907:9: note: here
    907 |         case LOAD_UNLOCK_RETRIES_STEP_LOCK:
        |         ^~~~
This commit is contained in:
Aleksander Morgado
2020-01-30 18:49:28 +01:00
parent 7e19ed0a79
commit 5ba6a684af
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/telit/mm-broadband-modem-telit.c
View File

@@ -615,8 +615,8 @@ qss_setup_step (GTask *task)
switch (ctx->step) { switch (ctx->step) {
case QSS_SETUP_STEP_FIRST: case QSS_SETUP_STEP_FIRST:
/* Fall back on next step */
ctx->step++; ctx->step++;
/* fall through */
case QSS_SETUP_STEP_QUERY: case QSS_SETUP_STEP_QUERY:
mm_base_modem_at_command (MM_BASE_MODEM (self), mm_base_modem_at_command (MM_BASE_MODEM (self),
"#QSS?", "#QSS?",
@@ -649,8 +649,8 @@ qss_setup_step (GTask *task)
task); task);
return; return;
} }
/* Fall back to next step */
ctx->step++; ctx->step++;
/* fall through */
case QSS_SETUP_STEP_LAST: case QSS_SETUP_STEP_LAST:
/* If all enabling actions failed (either both, or only primary if /* If all enabling actions failed (either both, or only primary if
* there is no secondary), then we return an error */ * there is no secondary), then we return an error */
@@ -905,8 +905,8 @@ load_unlock_retries_step (GTask *task)
ctx = g_task_get_task_data (task); ctx = g_task_get_task_data (task);
switch (ctx->step) { switch (ctx->step) {
case LOAD_UNLOCK_RETRIES_STEP_FIRST: case LOAD_UNLOCK_RETRIES_STEP_FIRST:
/* Fall back on next step */
ctx->step++; ctx->step++;
/* fall through */
case LOAD_UNLOCK_RETRIES_STEP_LOCK: case LOAD_UNLOCK_RETRIES_STEP_LOCK:
handle_csim_locking (task, TRUE); handle_csim_locking (task, TRUE);
break; break;