colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

api: new ID_MM_PORT_TYPE_QMI and ID_MM_PORT_TYPE_MBIM udev hints

Browse Source 
It is no longer true that all QMI ports are exposed by the qmi_wwan
driver and that all MBIM ports are exposed by the cdc_mbim driver.
There are other generic setups that allow exposing these types of
ports using different drivers, and usually we can also know the type
of port in advance via other means. Therefore, allow adding udev port
type hints for QMI and MBIM ports as well.
This commit is contained in:
Aleksander Morgado
2020-10-24 09:29:39 +02:00
parent e01c8b379c
commit c92dc21a18
4 changed files with 73 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/reference/api/ModemManager-docs.xml
View File

@@ -139,4 +139,8 @@
<title>Index of new symbols in 1.12</title>
<xi:include href="xml/api-index-1.12.xml"></xi:include>
</chapter>
<chapter id="api-index-1-16" role="1.16">
<title>Index of new symbols in 1.16</title>
<xi:include href="xml/api-index-1.16.xml"></xi:include>
</chapter>
</book>

2
docs/reference/api/ModemManager-sections.txt
View File

@@ -164,6 +164,8 @@ ID_MM_PORT_TYPE_AT_SECONDARY
ID_MM_PORT_TYPE_GPS
ID_MM_PORT_TYPE_QCDM
ID_MM_PORT_TYPE_AUDIO
ID_MM_PORT_TYPE_QMI
ID_MM_PORT_TYPE_MBIM
ID_MM_TTY_BAUDRATE
ID_MM_TTY_FLOW_CONTROL
</SECTION>

30
include/ModemManager-tags.h
View File

@@ -213,6 +213,36 @@
*/
#define ID_MM_PORT_TYPE_AUDIO "ID_MM_PORT_TYPE_AUDIO"
/**
* ID_MM_PORT_TYPE_QMI:
*
* This is a port-specific tag applied to generic ports that we know in advance
* are QMI ports.
*
* This tag will also prevent other types of probing (e.g. AT, MBIM) on the
* port.
*
* This tag is not required for QMI ports exposed by the qmi_wwan driver.
*
* Since: 1.16
*/
#define ID_MM_PORT_TYPE_QMI "ID_MM_PORT_TYPE_QMI"
/**
* ID_MM_PORT_TYPE_MBIM:
*
* This is a port-specific tag applied to generic ports that we know in advance
* are MBIM ports.
*
* This tag will also prevent other types of probing (e.g. AT, QMI) on the
* port.
*
* This tag is not required for MBIM ports exposed by the cdc_mbim driver.
*
* Since: 1.16
*/
#define ID_MM_PORT_TYPE_MBIM "ID_MM_PORT_TYPE_MBIM"
/**
* ID_MM_TTY_BAUDRATE:
*

46
src/mm-port-probe.c
View File

@@ -101,6 +101,8 @@ struct _MMPortProbePrivate {
gboolean maybe_at_secondary;
gboolean maybe_at_ppp;
gboolean maybe_qcdm;
gboolean maybe_qmi;
gboolean maybe_mbim;
/* Current probing task. Only one can be available at a time */
GTask *task;
@@ -1428,30 +1430,54 @@ mm_port_probe_run (MMPortProbe *self,
return;
}
/* If this is a port flagged as a GPS port, don't do any AT or QCDM probing */
/* If this is a port flagged as a GPS port, don't do any other probing */
if (self->priv->is_gps) {
mm_obj_dbg (self, "GPS port detected");
mm_port_probe_set_result_at (self, FALSE);
mm_port_probe_set_result_at (self, FALSE);
mm_port_probe_set_result_qcdm (self, FALSE);
mm_port_probe_set_result_qmi (self, FALSE);
mm_port_probe_set_result_mbim (self, FALSE);
}
/* If this is a port flagged as an audio port, don't do any AT or QCDM probing */
/* If this is a port flagged as an audio port, don't do any other probing */
if (self->priv->is_audio) {
mm_obj_dbg (self, "audio port detected");
mm_port_probe_set_result_at (self, FALSE);
mm_port_probe_set_result_at (self, FALSE);
mm_port_probe_set_result_qcdm (self, FALSE);
mm_port_probe_set_result_qmi (self, FALSE);
mm_port_probe_set_result_mbim (self, FALSE);
}
/* If this is a port flagged as being an AT port, don't do any QCDM probing */
/* If this is a port flagged as being an AT port, don't do any other probing */
if (self->priv->maybe_at_primary || self->priv->maybe_at_secondary || self->priv->maybe_at_ppp) {
mm_obj_dbg (self, "no QCDM probing in possible AT port");
mm_obj_dbg (self, "no QCDM/QMI/MBIM probing in possible AT port");
mm_port_probe_set_result_qcdm (self, FALSE);
mm_port_probe_set_result_qmi (self, FALSE);
mm_port_probe_set_result_mbim (self, FALSE);
}
/* If this is a port flagged as being a QCDM port, don't do any AT probing */
/* If this is a port flagged as being a QCDM port, don't do any other probing */
if (self->priv->maybe_qcdm) {
mm_obj_dbg (self, "no AT probing in possible QCDM port");
mm_port_probe_set_result_at (self, FALSE);
mm_obj_dbg (self, "no AT/QMI/MBIM probing in possible QCDM port");
mm_port_probe_set_result_at (self, FALSE);
mm_port_probe_set_result_qmi (self, FALSE);
mm_port_probe_set_result_mbim (self, FALSE);
}
/* If this is a port flagged as being a QMI port, don't do any other probing */
if (self->priv->maybe_qmi) {
mm_obj_dbg (self, "no AT/QCDM/MBIM probing in possible QMI port");
mm_port_probe_set_result_at (self, FALSE);
mm_port_probe_set_result_qcdm (self, FALSE);
mm_port_probe_set_result_mbim (self, FALSE);
}
/* If this is a port flagged as being a MBIM port, don't do any other probing */
if (self->priv->maybe_mbim) {
mm_obj_dbg (self, "no AT/QCDM/QMI probing in possible MBIM port");
mm_port_probe_set_result_at (self, FALSE);
mm_port_probe_set_result_qcdm (self, FALSE);
mm_port_probe_set_result_qmi (self, FALSE);
}
/* Check if we already have the requested probing results.
@@ -1819,6 +1845,8 @@ set_property (GObject *object,
self->priv->maybe_at_secondary = mm_kernel_device_get_property_as_boolean (self->priv->port, ID_MM_PORT_TYPE_AT_SECONDARY);
self->priv->maybe_at_ppp = mm_kernel_device_get_property_as_boolean (self->priv->port, ID_MM_PORT_TYPE_AT_PPP);
self->priv->maybe_qcdm = mm_kernel_device_get_property_as_boolean (self->priv->port, ID_MM_PORT_TYPE_QCDM);
self->priv->maybe_qmi = mm_kernel_device_get_property_as_boolean (self->priv->port, ID_MM_PORT_TYPE_QMI);
self->priv->maybe_mbim = mm_kernel_device_get_property_as_boolean (self->priv->port, ID_MM_PORT_TYPE_MBIM);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);