quectel: fix reference cycle

The 'update_settings' object must be referenced before the task is completed.
2022-01-18 10:29:45 +01:00
parent af0665c573
commit c9ffa2c9e5
1 changed files with 1 additions and 2 deletions
--- a/plugins/quectel/mm-shared-quectel.c
+++ b/plugins/quectel/mm-shared-quectel.c
@@ -158,9 +158,8 @@ quectel_get_firmware_version_ready (MMBaseModem  *modem,
    if (version)
        mm_firmware_update_settings_set_version (update_settings, version);

-    g_task_return_pointer (task, update_settings, g_object_unref);
+    g_task_return_pointer (task, g_object_ref (update_settings), g_object_unref);
    g_object_unref (task);
-    g_object_ref(update_settings);
 }

 static void