colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iface-modem-3gpp: ignore 'profile-id' and 'apn-type' matching initial EPS settings

Browse Source 
We should not try to match the 'profile-id', as that setting is not
available in the input bearer settings provided by the user.

And we should not try to match the 'apn-type', as not all
implementations support it and it's not really necessary for this
purpose anyway.
This commit is contained in:
Aleksander Morgado
2021-04-08 22:47:17 +02:00
parent 55f8e3b9a7
commit d5041cc814
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/mm-iface-modem-3gpp.c
View File

@@ -30,14 +30,20 @@
#define SUBSYSTEM_3GPP "3gpp"
/* When comparing EPS bearer settings take into account that PASSWORD may not always
* be readable, and apply very loose matching for all fields. Also, some implementations
* may allow configuring roaming allowance in the initial EPS bearer, but that is also
* not common. */
/* When comparing EPS bearer settings take into account that:
* - 'password' may not always be readable.
* - 'apn-type' may not always be supported.
* - 'profile-id' will not be known in the requested settings
* - we ignore settings not applicable to profiles, like 'allow-roaming' or
* 'rm-protocol'.
* - we apply very loose matching for all fields.
*/
#define MM_BEARER_PROPERTIES_CMP_FLAGS_EPS \
(MM_BEARER_PROPERTIES_CMP_FLAGS_LOOSE | \
MM_BEARER_PROPERTIES_CMP_FLAGS_NO_PROFILE_ID | \
MM_BEARER_PROPERTIES_CMP_FLAGS_NO_PASSWORD | \
MM_BEARER_PROPERTIES_CMP_FLAGS_NO_ALLOW_ROAMING | \
MM_BEARER_PROPERTIES_CMP_FLAGS_NO_APN_TYPE | \
MM_BEARER_PROPERTIES_CMP_FLAGS_NO_RM_PROTOCOL)
/*****************************************************************************/