colin/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

huawei: fix warnings with -Wsign-compare

Browse Source 
huawei/mm-modem-helpers-huawei.c: In function ‘mm_huawei_parse_prefmode_response’:
  huawei/mm-modem-helpers-huawei.c:550:18: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘const unsigned int’} [-Werror=sign-compare]
    550 |         if (mode == combination->prefmode)
        |                  ^~
This commit is contained in:
Aleksander Morgado
2020-01-30 18:14:08 +01:00
parent d6c3d8929e
commit dcce64a116
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/huawei/mm-modem-helpers-huawei.c
View File

@@ -521,7 +521,7 @@ mm_huawei_parse_prefmode_response (const gchar *response,
const GArray *supported_mode_combinations, const GArray *supported_mode_combinations,
GError **error) GError **error)
{ {
gint mode; guint mode;
guint i; guint i;
/* Format: /* Format:
@@ -530,7 +530,7 @@ mm_huawei_parse_prefmode_response (const gchar *response,
*/ */
response = mm_strip_tag (response, "^PREFMODE:"); response = mm_strip_tag (response, "^PREFMODE:");
if (!sscanf (response, "%d", &mode)) { if (!mm_get_uint_from_str (response, &mode)) {
/* Dump error to upper layer */ /* Dump error to upper layer */
g_set_error (error, g_set_error (error,
MM_CORE_ERROR, MM_CORE_ERROR,