We only want to ignore connected/connecting/disconnecting states
and update the state based on registration for unsolicited
registration changes. Basically, when disconnecting, the modem
will be in DISCONNECTING state, but after the disconnect has finished
we want to update the modem's state based on the current
registration status. But the previous check for >= DISCONNECTING
would prevent that from happening, so we need a slightly more specific
check in update_enabled_state().
Have to fall back to the previous state if the enable/disable
operation fails since we cannot assume anything about the new
modem state when a failure occurs.
By decoupling the solicited registration callback from unsolicited
replies, we can be sure of the call flow and avoid issues where
unsolicited registration will be processed when an explicit
registration request is no longer in progress.
Also ups the timeout on CREG=0,, to 120 seconds because that
appears to trigger an internal scan on some of the 'hso' devices
that I have, and can take up to 60 or more seconds to complete
or fail.
If there's already a command in-progress don't try to send
another until the previous one has timed out. Also use
g_timeout_add_seconds() since precision doesn't really matter for
command timeouts.
Should have ignored errors when cleaning up old contexts that
may or may not exist. Rename hso_disable() to something more
appropriate since it's actually part of the enable/connect path,
not the disable path.
Nozomi devices aren't quite ready when the ports show up, so
we have to keep trying to open the port for a few seconds and
eventually it'll succeed. Should really be fixed in the driver
(ie, don't create the ttys until they can actually be used) but
whatever.
If the modem becomes invalid (it crashes and resets, for example)
the callback-info's modem_destroyed_cb() function will handle
cleanup. Buf if the callback-info's callback does more work than
just returning the result (like simple_state_machine) it could
double-schedule the callback. Don't let that happen.
We need better modem-removal handling, but this fixes a crash for
now.
Some ZTE devices (MF626 for example) will emit the ZPASR unsolicited
response right after MM opens the port, and they will just throw the
init string away. So retry the init string once; the ZTE devices will
see it the second time and continue as normal.
This is the MM version of NM commit 861e9689c513cbd61fa75205a681a69d4ba8236c
0.7 hasn't used spaces for over a year, so this is a pretty safe
change. Some modems just don't like it.
0.7 commit to remove spaces:
commit 0265bfe52dcc93372aff6064e849044ccb72aa1e
Author: Dan Williams <dcbw@redhat.com>
Date: Fri Oct 24 15:15:06 2008 +0000
2008-10-24 Dan Williams <dcbw@redhat.com>
* src/nm-gsm-device.c
- (set_apn): remove erroneous spaces in AT+CGDCONT command (Jerone Young)
gcc will interpret the constant value as a uint32 but
the port's set_property() was taking it as a uint64. Thus
the top 32 bits were probably garbage, and messed up
on big-endian architectures leading to random large
probe delays.
The standard dictates CSQ response strength value to be [0 - 31]
inclusive, and 99 means "unknown" or "no service". Make that
apparent and don't treat 99 as 99% which it clearly isn't. Also,
allow spaces in the CSQ response.
