colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sriov: do not fail activation on SR-IOV VF failures

Browse Source 
When user are changing SR-IOV VF settings for options like `max-tx-rate`
which some hardware not supported yet, the failure of this VF will fail
the whole activation, then the SR-IOV will be disabled means all the VFs
will be deleted.

Deleting VFs might break network connectivity and this collateral
damage of VF option failure is not acceptable for OpenShift use cases
even they have checkpoint protection.

This patch only log warn message on failure of VF options and will not
fail the activation.

NetworkManager also ignore MTU failure during activation, I believe this
fit into the same assumption.

User case reference: https://bugzilla.redhat.com/show_bug.cgi?id=2210164

Signed-off-by: Gris Ge <fge@redhat.com>
This commit is contained in:
Gris Ge
2023-06-28 22:36:41 +08:00
parent 7e2f2174ab
commit 02b892149a
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/devices/nm-device.c
View File

@@ -9590,11 +9590,7 @@ sriov_params_cb(GError *error, gpointer user_data)
if (!nm_platform_link_set_sriov_vfs(nm_device_get_platform(self),
priv->ifindex,
(const NMPlatformVF *const *) plat_vfs)) {
_LOGE(LOGD_DEVICE, "failed to apply SR-IOV VFs");
nm_device_state_changed(self,
NM_DEVICE_STATE_FAILED,
NM_DEVICE_STATE_REASON_SRIOV_CONFIGURATION_FAILED);
return;
_LOGW(LOGD_DEVICE, "failed to apply SR-IOV VF configurations");
}
priv->stage1_sriov_state = NM_DEVICE_STAGE_STATE_COMPLETED;