colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libnm-core: Don't warn on missing properties

Browse Source 
It might simply mean that the object disappeared (which is perfectly fine):

(process:7680): libnm-WARNING **: Could not fetch property 'Vpn' of interface 'org.freedesktop.NetworkManager.Connection.Active' on /org/freedesktop/NetworkManager/ActiveConnection/151: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist

https://bugzilla.gnome.org/show_bug.cgi?id=739255
This commit is contained in:
Lubomir Rintel
2014-10-27 18:43:38 +01:00
parent bd2829f355
commit 5aefbe5658
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libnm/nm-object.c
View File

@@ -632,7 +632,7 @@ _nm_object_create (GType type, GDBusConnection *connection, const char *path)
NULL, &error); NULL, &error);
g_object_unref (proxy); g_object_unref (proxy);
if (!ret) { if (!ret) {
g_warning ("Could not fetch property '%s' of interface '%s' on %s: %s\n", dbgmsg ("Could not fetch property '%s' of interface '%s' on %s: %s\n",
type_data->property, type_data->interface, path, error->message); type_data->property, type_data->interface, path, error->message);
g_error_free (error); g_error_free (error);
return NULL; return NULL;
@@ -753,7 +753,7 @@ create_async_got_property (GObject *proxy, GAsyncResult *result, gpointer user_d
g_variant_unref (value); g_variant_unref (value);
g_variant_unref (ret); g_variant_unref (ret);
} else { } else {
g_warning ("Could not fetch property '%s' of interface '%s' on %s: %s\n", dbgmsg ("Could not fetch property '%s' of interface '%s' on %s: %s\n",
type_data->property, type_data->interface, async_data->path, type_data->property, type_data->interface, async_data->path,
error->message); error->message);
g_clear_error (&error); g_clear_error (&error);

2
libnm/tests/test-nm-client.c
View File

@@ -1049,9 +1049,7 @@ test_activate_failed (void)
nm_client_add_and_activate_connection_async (client, conn, device, NULL, nm_client_add_and_activate_connection_async (client, conn, device, NULL,
NULL, activate_failed_cb, NULL); NULL, activate_failed_cb, NULL);
g_test_expect_message ("libnm", G_LOG_LEVEL_WARNING, "*Method*doesn't exist*");
g_main_loop_run (loop); g_main_loop_run (loop);
g_test_assert_expected_messages ();
g_object_unref (conn); g_object_unref (conn);
g_object_unref (client); g_object_unref (client);