colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cli: fix reading IP config for *-slaves

Browse Source 
Error found by running Coverity

https://bugzilla.redhat.com/show_bug.cgi?id=1025894

Signed-off-by: Thomas Haller <thaller@redhat.com>
This commit is contained in:
Thomas Haller
2013-11-01 19:47:07 +01:00
parent 0139ad37f7
commit ab92a0d69c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cli/src/connections.c
View File

@@ -4227,24 +4227,26 @@ cleanup_olpc:
if (!nmc_parse_args (exp_args, TRUE, &argc, &argv, error)) if (!nmc_parse_args (exp_args, TRUE, &argc, &argv, error))
return FALSE; return FALSE;
/* coverity[dead_error_begin] */
if (ip4) { if (ip4) {
ip4addr = nmc_parse_and_build_ip4_address (ip4, gw4, error); ip4addr = nmc_parse_and_build_ip4_address (ip4, gw4, error);
if (!ip4addr) { if (!ip4addr) {
g_prefix_error (error, _("Error: ")); g_prefix_error (error, _("Error: "));
return FALSE; return FALSE;
} }
}
add_ip4_address_to_connection (ip4addr, connection); add_ip4_address_to_connection (ip4addr, connection);
}
/* coverity[dead_error_begin] */
if (ip6) { if (ip6) {
ip6addr = nmc_parse_and_build_ip6_address (ip6, gw6, error); ip6addr = nmc_parse_and_build_ip6_address (ip6, gw6, error);
if (!ip6addr) { if (!ip6addr) {
g_prefix_error (error, _("Error: ")); g_prefix_error (error, _("Error: "));
return FALSE; return FALSE;
} }
}
add_ip6_address_to_connection (ip6addr, connection); add_ip6_address_to_connection (ip6addr, connection);
} }
}
/* Ask for addresses if '--ask' is specified. */ /* Ask for addresses if '--ask' is specified. */
if (ask) if (ask)