colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nmcli/connections: fix build with libedit

Browse Source 
This has always been broken (libedit-0:3.1-17.20160618cvs.fc26 is too
old to work and libedit-0:3.1-20.20170329cvs.fc27.x86_64 has this type
mismatch), but new GCC complains (14, 15).

  ../src/nmcli/connections.c: In function ‘nmcli_editor_tab_completion’:
  ../src/nmcli/connections.c:6862:64: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]
   6862 |                             rl_completion_display_matches_hook = uuid_display_hook;
        |                                                                ^
  ../src/nmcli/connections.c:6909:60: error: assignment to ‘void (*)(char **, int,  int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]
   6909 |                         rl_completion_display_matches_hook = uuid_display_hook;
        |                                                            ^

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2172
This commit is contained in:
Lubomir Rintel
2025-03-31 18:08:56 +02:00
parent 7ab3f0999f
commit cc0222ba01
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nmcli/connections.c
View File

@@ -6074,7 +6074,7 @@ finish:
/* Functions for readline TAB completion in editor */
#if HAVE_EDITLINE_READLINE
#define uuid_display_hook ((void (*)(void)) NULL)
#define uuid_display_hook ((void (*)(char **, int, int)) NULL)
#else
static void
uuid_display_hook(char **array, int len, int max_len)