colin/NetworkManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform: no need to initialize nla sockaddr parameter to nl_recv()

Browse Source 
We always call nl_recv() in a loop. If it would be necessary to clear
the variable, then it would need to happen inside the loop. But it's
not necessary.
This commit is contained in:
Thomas Haller
2022-01-25 14:19:00 +01:00
parent dd3dffb1b0
commit d73594682f
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libnm-platform/nm-linux-platform.c
View File

@@ -9040,7 +9040,7 @@ event_handler_recvmsgs(NMPlatform *platform, gboolean handle_events)
gboolean interrupted = FALSE; gboolean interrupted = FALSE;
struct nlmsghdr *hdr; struct nlmsghdr *hdr;
WaitForNlResponseResult seq_result; WaitForNlResponseResult seq_result;
struct sockaddr_nl nla = {0}; struct sockaddr_nl nla;
struct ucred creds; struct ucred creds;
gboolean creds_has; gboolean creds_has;
unsigned char *buf; unsigned char *buf;

2
src/libnm-platform/nm-netlink.c
View File

@@ -1171,7 +1171,7 @@ nl_recvmsgs(struct nl_sock *sk, const struct nl_cb *cb)
int n, nmerr = 0, multipart = 0, interrupted = 0, nrecv = 0; int n, nmerr = 0, multipart = 0, interrupted = 0, nrecv = 0;
gs_free unsigned char *buf = NULL; gs_free unsigned char *buf = NULL;
struct nlmsghdr *hdr; struct nlmsghdr *hdr;
struct sockaddr_nl nla = {0}; struct sockaddr_nl nla;
struct ucred creds; struct ucred creds;
gboolean creds_has; gboolean creds_has;