colin/Signal-Desktop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "optimize timeline scroll performance"

Browse Source
This commit is contained in:
Jamie Kyle
2023-08-01 10:24:45 -07:00
committed by GitHub
parent 827dc66220
commit 1c9651f557
1 changed files with 4 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
ts/components/conversation/Timeline.tsx
View File

@@ -399,14 +399,12 @@ export class Timeline extends React.Component<
const newestBottomVisibleMessageId =
getMessageIdFromElement(newestBottomVisible);
this.updatePartiallyVisibleMessageIds(
this.setState({
oldestPartiallyVisibleMessageId,
newestBottomVisibleMessageId
);
newestBottomVisibleMessageId,
});
if (this.props.isNearBottom !== newIsNearBottom) {
setIsNearBottom(id, newIsNearBottom);
}
setIsNearBottom(id, newIsNearBottom);
if (newestBottomVisibleMessageId) {
this.markNewestBottomVisibleMessageRead();
@@ -463,19 +461,6 @@ export class Timeline extends React.Component<
this.intersectionObserver.observe(atBottomDetectorEl);
}
private updatePartiallyVisibleMessageIds = throttle(
(
oldestPartiallyVisibleMessageId: string | undefined,
newestBottomVisibleMessageId: string | undefined
) => {
this.setState({
oldestPartiallyVisibleMessageId,
newestBottomVisibleMessageId,
});
},
100
);
private markNewestBottomVisibleMessageRead = throttle((): void => {
const { id, markMessageRead } = this.props;
const { newestBottomVisibleMessageId } = this.state;