Drop pniCredential completely

ts/model-types.d.ts

@@ -311,8 +311,6 @@ export type ConversationAttributesType = {
   };
   profileKeyCredential?: string | null;
   profileKeyCredentialExpiration?: number | null;
-  // TODO: DESKTOP-4223
-  pniCredential?: void;
   lastProfile?: ConversationLastProfileType;
   quotedMessageId?: string | null;
   sealedSender?: unknown;

ts/services/profiles.ts

@@ -341,10 +341,6 @@ async function doGetProfile(c: ConversationModel): Promise<void> {
       }
     }
 
-    if (isMe(c.attributes)) {
-      c.unset('pniCredential');
-    }
-
     if (profile.identityKey) {
       await updateIdentityKey(profile.identityKey, uuid);
     }