Move react-dev-tools-core to dev dependencies (#9902)

ACKNOWLEDGMENTS.md

@@ -2790,10 +2790,6 @@ Signal Desktop makes use of the following open source projects.
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
 
-## react-devtools-core
-
-    License: MIT
-
 ## react-dom
 
     MIT License

package.json

@@ -179,7 +179,6 @@
     "react-aria-components": "1.4.1",
     "react-blurhash": "0.3.0",
     "react-contextmenu": "2.14.0",
-    "react-devtools-core": "6.0.1",
     "react-dom": "17.0.2",
     "react-hot-loader": "4.13.1",
     "react-intl": "6.8.7",
@@ -324,6 +323,7 @@
     "prettier": "3.3.3",
     "protobufjs-cli": "1.1.1",
     "react-devtools": "6.0.1",
+    "react-devtools-core": "6.0.1",
     "resedit": "2.0.2",
     "resolve-url-loader": "5.0.0",
     "sass": "1.80.7",

pnpm-lock.yaml

@@ -307,9 +307,6 @@ importers:
       react-contextmenu:
         specifier: 2.14.0
         version: 2.14.0(patch_hash=5ec508240616a7d029c1f80185121cada9d4587b179f7c7a7ffa02b6bf02e043)(prop-types@15.8.1)(react-dom@17.0.2(react@17.0.2))(react@17.0.2)
-      react-devtools-core:
-        specifier: 6.0.1
-        version: 6.0.1(bufferutil@4.0.9)(utf-8-validate@5.0.10)
       react-dom:
         specifier: 17.0.2
         version: 17.0.2(react@17.0.2)
@@ -737,6 +734,9 @@ importers:
       react-devtools:
         specifier: 6.0.1
         version: 6.0.1(bufferutil@4.0.9)(utf-8-validate@5.0.10)
+      react-devtools-core:
+        specifier: 6.0.1
+        version: 6.0.1(bufferutil@4.0.9)(utf-8-validate@5.0.10)
       resedit:
         specifier: 2.0.2
         version: 2.0.2

ts/windows/main/phase0-devtools.ts

@@ -2,13 +2,17 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 import '../context';
-import { initialize, connectToDevTools } from 'react-devtools-core';
 import { Environment, getEnvironment } from '../../environment';
 
 if (
   getEnvironment() === Environment.Development &&
   Boolean(process.env.REACT_DEVTOOLS)
 ) {
+  // Not bundled in the production app
+  // eslint-disable-next-line max-len
+  // eslint-disable-next-line global-require, import/no-extraneous-dependencies, @typescript-eslint/no-var-requires
+  const { initialize, connectToDevTools } = require('react-devtools-core');
+
   initialize();
   connectToDevTools();
 }