mpv/ffmpeg: consolidate the different ffmpeg configs into overlays/preferences

hosts/common/programs/kdenlive.nix

@@ -1,13 +1,6 @@
 { pkgs, ... }:
 {
   sane.programs.kdenlive = {
-    packageUnwrapped = pkgs.kdenlive.override {
-      ffmpeg-full = pkgs.ffmpeg-full.override {
-        # avoid expensive samba build for a feature i don't use
-        withSamba = false;
-      };
-    };
-
     buildCost = 1;
 
     sandbox.method = "bwrap";

hosts/common/programs/mpv/default.nix

@@ -146,7 +146,10 @@ in
         # i think using `luajit` here instead of `lua` is optional, just i get better perf with it :)
         lua = pkgs.luajit.override { enable52Compat = true; self = lua; };
         # ship a ffmpeg with sofa enabled, for surround-sound downmixing
-        ffmpeg = pkgs.ffmpeg-full;
+        # ffmpeg = pkgs.ffmpeg-full;
+        ffmpeg = pkgs.ffmpeg.override {
+          withMysofa = true;
+        };
       };
       scripts = [
         pkgs.mpvScripts.mpris

overlays/preferences.nix

@@ -13,6 +13,15 @@
     enableOAuth2 = false;
   };
 
+  ffmpeg = super.ffmpeg.override {
+    # required by mpv for spatial audio; enable it globally to avoid shipping many ffmpegs
+    withMysofa = true;
+  };
+  ffmpeg-full = super.ffmpeg-full.override {
+    # saves 20 minutes of build time and cross issues, for unused feature
+    withSamba = false;
+  };
+
   gnome = super.gnome.overrideScope (gself: gsuper: with gself; {
     gnome-control-center = gsuper.gnome-control-center.override {
       # i build goa without the "backend", to avoid webkit_4_1.