colin/nix-files
1
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

sway: patch to temporarily allow any window to request activation (fix for notifications)

Browse Source
This commit is contained in:
Colin
2023-09-09 09:32:00 +00:00
parent 75009f6816
commit cc78c3c36e
1 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
overlays/preferences.nix
View File

@@ -19,6 +19,22 @@
# };
});
# dino = super.dino.override {
# gtk4 = gtk4.overrideAttrs (upstream: {
# patches = (upstream.patches or []) ++ [
# (fetchpatch2 {
# # 2023/09/08: this allows gtk4 apps to request window activation from sway more reliably.
# # e.g. if they send a notification, and i click that notification, the app can request focus.
# # without this patch, dino (and probably other gtk4 apps) have quirks on moby:
# # - they can only request activation after i've typed something into them (i.e. triggered a keyboard event for which they're listening).
# name = "gdk/wayland: Provide latest touch serial even after a touch ended";
# url = "https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5782.patch";
# hash = "sha256-OwOUAFB+Q+FJ+TEDohfpA2stHPq3c0cAFfJf3mFRvPQ=";
# })
# ];
# });
# };
phog = super.phog.override {
# disable squeekboard because it takes 20 minutes to compile when emulated
squeekboard = null;
@@ -64,4 +80,31 @@
# should be safe to remove after next staging -> master merge
jackSupport = false;
};
sway-unwrapped = super.sway-unwrapped.override {
wlroots = wlroots.overrideAttrs (upstream: {
# 2023/09/08: fix so clicking a notification can activate the corresponding window.
# - test: run dino, receive a message while tabbed away, click the desktop notification.
# - if sway activates the dino window (i.e. colors the workspace and tab), then all good
# - do all of this with only a touchscreen (e.g. on mobile phone) -- NOT a mouse/pointer
## what this patch does:
# - allows any wayland window to request activation, at any time.
# - traditionally, wayland only allows windows to request activation if
# the client requesting to transfer control has some connection to a recent user interaction.
# - e.g. the active window may transfer control to any window
# - a window which was very recently active may transfer control to itself
## alternative (longer-term) solutions:
# - fix this class of bug in gtk:
# - <https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5782>
# - N.B.: this linked PR doesn't actually fix it
# - add xdg_activation_v1 support to SwayNC (my notification daemon):
# - <https://github.com/ErikReider/SwayNotificationCenter/issues/71>
# - mako notification daemon supports activation, can use as a reference
# - all of ~30 LoC, looks straight-forward
postPatch = (upstream.postPatch or "") + ''
substituteInPlace types/wlr_xdg_activation_v1.c \
--replace 'if (token->seat != NULL)' 'if (false && token->seat != NULL)'
'';
});
};
})