colin/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

doc/reviewing-contributions: Remove wrong fetchpatch detail

Browse Source 
It may have to be fetchpatch, fetchpatch2, or fetchurl. We should link somewhere, but we don't have a link target yet, so until then, remove the inaccurate info.

Co-authored-by: Alyssa Ross <hi@alyssa.is>
This commit is contained in:
Robert Hensing 2023-06-27 18:35:15 +02:00 committed by GitHub
parent 4920af40fc
commit a0a4354a13
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/contributing/reviewing-contributions.chapter.md
View File

@ -63,7 +63,7 @@ Sample template for a package update review is provided below.
- [ ] executables tested on ARCHITECTURE
- [ ] all depending packages build
- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- [ ] patches that are remotely available are fetched with `fetchpatch`
- [ ] patches that are remotely available are fetched rather than vendored
##### Possible improvements
@ -108,7 +108,7 @@ Sample template for a new package review is provided below.
- [ ] the list of `phases` is not overridden
- [ ] when a phase (like `installPhase`) is overridden it starts with `runHook preInstall` and ends with `runHook postInstall`.
- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- [ ] patches that are remotely available are fetched with `fetchpatch`
- [ ] patches that are remotely available are fetched rather than vendored
##### Possible improvements