Added todo

libremsonic/cache_manager.py

@@ -585,10 +585,11 @@ class CacheManager(metaclass=Singleton):
 
             return (str(abs_path), False)
 
-        def get_genres(self,
+        def get_genres(
+                self,
                 before_download: Callable[[], None] = lambda: None,
                 force: bool = False,
-                       ) -> Future:
+        ) -> Future:
             def do_get_genres() -> List[Genre]:
                 if not self.cache['genres'] or force:
                     before_download()

libremsonic/ui/albums.py

@@ -114,6 +114,11 @@ class AlbumsPanel(Gtk.Box):
     def populate_genre_combo(self):
         def get_genres_done(f):
             model = self.genre_combo.get_model()
+
+            # TODO enabling this infinite loops the program, I think due to the
+            # fact that it triggers a genre change event. Fix this with some
+            # locks.
+            # model.clear()
             for genre in (f.result() or []):
                 model.append((genre.value, genre.value))