colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmd: sf: prevent overwriting the reserved memory

Browse Source 
Added LMB API to prevent SF command from overwriting reserved
memory areas. The current SPI code does not use LMB APIs for
loading data into memory addresses. To resolve this, LMB APIs
were added to check the load address of an SF command and ensure it
does not overwrite reserved memory addresses. Similar checks are
used in TFTP, serial load, and boot code to prevent overwriting
reserved memory.

Signed-off-by: Prasad Kummari <prasad.kummari@amd.com>
Suggested-by: Sughosh Ganu <sughosh.ganu@linaro.org>
This commit is contained in:
Prasad Kummari
2024-09-13 13:02:52 +05:30
committed by Tom Rini
parent 948616894c
commit 33a4dfc703
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/sf.c
View File

@@ -10,6 +10,7 @@
#include <div64.h>
#include <dm.h>
#include <log.h>
#include <lmb.h>
#include <malloc.h>
#include <mapmem.h>
#include <spi.h>
@@ -317,6 +318,13 @@ static int do_spi_flash_read_write(int argc, char *const argv[])
strncmp(argv[0], "write", 5) == 0) {
int read;
if (CONFIG_IS_ENABLED(LMB)) {
if (lmb_read_check(addr, len)) {
printf("ERROR: trying to overwrite reserved memory...\n");
return CMD_RET_FAILURE;
}
}
read = strncmp(argv[0], "read", 4) == 0;
if (read)
ret = spi_flash_read(flash, offset, len, buf);

5
include/lmb.h
View File

@@ -111,6 +111,11 @@ struct lmb *lmb_get(void);
int lmb_push(struct lmb *store);
void lmb_pop(struct lmb *store);
static inline int lmb_read_check(phys_addr_t addr, phys_size_t len)
{
return lmb_alloc_addr(addr, len) == addr ? 0 : -1;
}
#endif /* __KERNEL__ */
#endif /* _LINUX_LMB_H */