colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge patch series "Enable UNIT_TEST for all qemu* generic targets"

Browse Source 
Jerome Forissier <jerome.forissier@linaro.org> says:

Enable CONFIG_UNIT_TEST in most of the configs/qemu*_defconfig files
to increase test coverage in CI, and fix what needs to be fixed.

Link: https://lore.kernel.org/r/20250416135744.1995084-1-jerome.forissier@linaro.org
This commit is contained in:
Tom Rini
2025-04-22 12:26:44 -06:00
parent b867932191 753b7219c2
commit 9adeadfbf7
10 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
configs/qemu-arm-sbsa_defconfig
View File

@@ -9,3 +9,4 @@ CONFIG_EFI_PARTITION=y
CONFIG_PARTITION_TYPE_GUID=y
CONFIG_EFI_MEDIA=y
CONFIG_FS_FAT=y
CONFIG_UNIT_TEST=y

1
configs/qemu-ppce500_defconfig
View File

@@ -66,3 +66,4 @@ CONFIG_VIRTIO_NET=y
CONFIG_VIRTIO_BLK=y
CONFIG_ADDR_MAP=y
CONFIG_PANIC_HANG=y
CONFIG_UNIT_TEST=y

1
configs/qemu-riscv32_defconfig
View File

@@ -20,3 +20,4 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_DM_MTD=y
CONFIG_FLASH_SHOW_PROGRESS=0
CONFIG_SYS_MAX_FLASH_BANKS=2
CONFIG_UNIT_TEST=y

1
configs/qemu-riscv32_smode_defconfig
View File

@@ -21,3 +21,4 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_DM_MTD=y
CONFIG_FLASH_SHOW_PROGRESS=0
CONFIG_SYS_MAX_FLASH_BANKS=2
CONFIG_UNIT_TEST=y

1
configs/qemu-riscv32_spl_defconfig
View File

@@ -26,3 +26,4 @@ CONFIG_DM_MTD=y
CONFIG_FLASH_SHOW_PROGRESS=0
CONFIG_SYS_MAX_FLASH_BANKS=2
# CONFIG_BINMAN_FDT is not set
CONFIG_UNIT_TEST=y

1
configs/qemu-riscv64_defconfig
View File

@@ -20,3 +20,4 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_DM_MTD=y
CONFIG_FLASH_SHOW_PROGRESS=0
CONFIG_SYS_MAX_FLASH_BANKS=2
CONFIG_UNIT_TEST=y

1
configs/qemu-riscv64_smode_defconfig
View File

@@ -23,3 +23,4 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_DM_MTD=y
CONFIG_FLASH_SHOW_PROGRESS=0
CONFIG_SYS_MAX_FLASH_BANKS=2
CONFIG_UNIT_TEST=y

1
configs/qemu-riscv64_spl_defconfig
View File

@@ -25,3 +25,4 @@ CONFIG_DM_MTD=y
CONFIG_FLASH_SHOW_PROGRESS=0
CONFIG_SYS_MAX_FLASH_BANKS=2
# CONFIG_BINMAN_FDT is not set
CONFIG_UNIT_TEST=y

1
configs/qemu-x86_64_defconfig
View File

@@ -93,3 +93,4 @@ CONFIG_SPL_VIDEO=y
CONFIG_GENERATE_ACPI_TABLE=y
CONFIG_CMD_DHRYSTONE=y
# CONFIG_GZIP is not set
CONFIG_UNIT_TEST=y

31
test/cmd/command.c
View File

@@ -45,31 +45,32 @@ static int command_test(struct unit_test_state *uts)
"setenv list ${list}3", strlen("setenv list 1"), 0);
ut_assert(!strcmp("1", env_get("list")));
ut_asserteq(1, run_command("false", 0));
ut_assertok(run_command("echo", 0));
ut_asserteq(1, run_command_list("false", -1, 0));
ut_assertok(run_command_list("echo", -1, 0));
#ifdef CONFIG_HUSH_PARSER
run_command("setenv foo 'setenv black 1\nsetenv adder 2'", 0);
run_command("run foo", 0);
ut_assertnonnull(env_get("black"));
ut_asserteq(0, strcmp("1", env_get("black")));
ut_assertnonnull(env_get("adder"));
ut_asserteq(0, strcmp("2", env_get("adder")));
#endif
ut_assertok(run_command("", 0));
ut_assertok(run_command(" ", 0));
if (IS_ENABLED(CONFIG_HUSH_PARSER)) {
ut_asserteq(1, run_command("false", 0));
ut_asserteq(1, run_command_list("false", -1, 0));
run_command("setenv foo 'setenv black 1\nsetenv adder 2'", 0);
run_command("run foo", 0);
ut_assertnonnull(env_get("black"));
ut_asserteq(0, strcmp("1", env_get("black")));
ut_assertnonnull(env_get("adder"));
ut_asserteq(0, strcmp("2", env_get("adder")));
ut_assertok(run_command("", 0));
ut_assertok(run_command(" ", 0));
}
ut_asserteq(1, run_command("'", 0));
/* Variadic function test-cases */
if (IS_ENABLED(CONFIG_HUSH_PARSER)) {
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wformat-zero-length"
ut_assertok(run_commandf(""));
ut_assertok(run_commandf(""));
#pragma GCC diagnostic pop
ut_assertok(run_commandf(" "));
ut_assertok(run_commandf(" "));
}
ut_asserteq(1, run_commandf("'"));
ut_assertok(run_commandf("env %s %s", "delete -f", "list"));