colin/wireplumber
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

m-settings: remove all persistent settings if key is null

Browse Source 
The wp_settings_delete_all() API internally uses wp_metadata_clear() to clear
all the keys in the persistent-sm-settings metadata object. This call emits
the metadata changed signal with both 'key' and 'value' set to NULL. When that
happens, we need to clear all settings from the state file.
This commit is contained in:
Julian Bouzas
2024-03-22 20:26:42 -04:00
committed by George Kiagiadakis
parent b16763f8d4
commit 291d3cd9a2
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
modules/module-settings.c
View File

@@ -64,12 +64,21 @@ on_persistent_metadata_changed (WpMetadata *m, guint32 subject,
WpSettingsPlugin *self = WP_SETTINGS_PLUGIN (d);
g_autoptr (WpCore) core = wp_object_get_core (WP_OBJECT (self));
/* Update persistent settings with new value and timeout save it */
wp_properties_set (self->persistent_settings, key, value);
if (value)
wp_info_object (self, "persistent setting updated: %s = %s", key, value);
else
wp_info_object (self, "persistent setting removed: %s", key);
/* Update persistent settings with new value. If key is null it means all
* settings need to be removed */
if (key) {
wp_properties_set (self->persistent_settings, key, value);
if (value)
wp_info_object (self, "persistent setting updated: %s = %s", key, value);
else
wp_info_object (self, "persistent setting removed: %s", key);
} else {
g_clear_pointer (&self->persistent_settings, wp_properties_unref);
self->persistent_settings = wp_properties_new_empty ();
wp_info_object (self, "all persistent settings removed");
}
/* Save changes */
wp_state_save_after_timeout (self->state, core, self->persistent_settings);
/* Also update current settings with new value */