colin/wireplumber
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

object-manager: set self->installed=TRUE before emiting the signal

Browse Source 
This avoids recursing into the same signal, in rare cases where a
new object is registered from within the signal handler
This commit is contained in:
George Kiagiadakis
2023-04-11 22:06:21 +03:00
committed by Julian Bouzas
parent 8505e75cd0
commit e55e8bb447
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/wp/object-manager.c
View File

@@ -663,8 +663,8 @@ idle_emit_objects_changed (WpObjectManager * self)
if (G_UNLIKELY (!self->installed)) {
wp_trace_object (self, "installed");
g_signal_emit (self, signals[SIGNAL_INSTALLED], 0);
self->installed = TRUE;
g_signal_emit (self, signals[SIGNAL_INSTALLED], 0);
}
wp_trace_object (self, "emit objects-changed");
g_signal_emit (self, signals[SIGNAL_OBJECTS_CHANGED], 0);
@@ -717,8 +717,8 @@ wp_object_manager_maybe_objects_changed (WpObjectManager * self)
WpRegistry *reg = wp_core_get_registry (core);
if (reg->tmp_globals->len == 0 && reg->globals->len != 0) {
wp_trace_object (self, "installed");
g_signal_emit (self, signals[SIGNAL_INSTALLED], 0);
self->installed = TRUE;
g_signal_emit (self, signals[SIGNAL_INSTALLED], 0);
}
}
}