does not return to correct page after a bookmark creation

This commit is contained in:
Marc Delisle
2005-12-20 13:14:44 +00:00
parent 16a71a194e
commit 024261a924
2 changed files with 5 additions and 1 deletions

View File

@@ -5,6 +5,10 @@ phpMyAdmin - Changelog
$Id$
$Source$
2005-12-20 Marc Delisle <lem9@users.sourceforge.net>
* libraries/common.lib.php: does not return to correct page after
the creation of a bookmark
2005-12-17 Sebastian Mendel <cybot_tm@users.sourceforge.net>
* db_details_importdocsql.php, db_operations.php,
libraries\relation.lib.php, libraries\relation_cleanup.lib.php

View File

@@ -2692,7 +2692,7 @@ if (!in_array($__redirect, $goto_whitelist)) {
* @var string $goto holds page that should be displayed
*/
// Security fix: disallow accessing serious server files via "?goto="
if (isset($_REQUEST['goto']) && in_array($_REQUEST['goto'], $goto_whitelist)) {
if (isset($_REQUEST['goto']) && in_array(substr($_REQUEST['goto'], 0, strpos($_REQUEST['goto'] . '?', '?')), $goto_whitelist)) {
$GLOBALS['goto'] = $_REQUEST['goto'];
$GLOBALS['url_params']['goto'] = $goto;
} else {