bug #1989813 [interface] Deleting multiple views (space in name)

This commit is contained in:
Marc Delisle
2008-06-24 17:33:50 +00:00
parent d4074c1976
commit 26c46c19dc
2 changed files with 7 additions and 2 deletions

View File

@@ -15,6 +15,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
- bug [XHTML] problem with tabindex and radio fields
- bug #1971221 [interface] tabindex not set correctly
- bug [views] VIEW name created via the GUI was not protected with backquotes
- bug #1989813 [interface] Deleting multiple views (space in name)
2.11.7.0 (2008-06-23)
- bug #1908719 [interface] New field cannot be auto-increment and primary key

View File

@@ -160,7 +160,9 @@ if (!empty($submit_mult) && !empty($what)) {
case 'drop_tbl':
$current = urldecode($sval);
if (!empty($views) && in_array($current, $views)) {
// here we must compare with the value before urldecode()
// because $views has been treated with htmlspecialchars()
if (!empty($views) && in_array($sval, $views)) {
$full_query_views .= (empty($full_query_views) ? 'DROP VIEW ' : ', ')
. PMA_backquote(htmlspecialchars($current));
} else {
@@ -322,7 +324,9 @@ elseif ($mult_btn == $strYes) {
case 'drop_tbl':
PMA_relationsCleanupTable($db, $selected[$i]);
$current = urldecode($selected[$i]);
if (!empty($views) && in_array($current, $views)) {
// here we must compare with the value before urldecode()
// because $views has been treated with htmlspecialchars()
if (!empty($views) && in_array($selected[$i], $views)) {
$sql_query_views .= (empty($sql_query_views) ? 'DROP VIEW ' : ', ')
. PMA_backquote($current);
} else {