Do not save too big queries in history

This commit is contained in:
Marc Delisle
2008-07-09 14:17:19 +00:00
parent 39725e9dfb
commit 4025975910
4 changed files with 7 additions and 2 deletions

View File

@@ -20,6 +20,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
- bug #1989281 [export] CSV for MS Excel incorrect escaping of double quotes
- bug #1959855 [interface] Font size option problem when no config file
- bug #1982489 [relation] Relationship view should check for changes
- bug [history] Do not save too big queries in history
2.11.7.0 (2008-06-23)
- bug #1908719 [interface] New field cannot be auto-increment and primary key

View File

@@ -1107,7 +1107,8 @@ ALTER TABLE `pma_column_comments`
<dd>The maximum number of characters when a SQL query is displayed. The
default limit of 1000 should be correct to avoid the display of tons
of hexadecimal codes that represent BLOBs, but some users have real
SQL queries that are longer than 1000 characters.</dd>
SQL queries that are longer than 1000 characters. Also, if a query's
length exceeds this limit, this query is not saved in the history.</dd>
<dt id="cfg_OBGzip">$cfg['OBGzip'] string/boolean</dt>
<dd>Defines whether to use GZip output buffering for increased

View File

@@ -711,6 +711,7 @@ function PMA_setComment($db, $table, $col, $comment, $removekey = '', $mode = 'a
*
* @uses $_SESSION['sql_history']
* @uses $cfg['QueryHistoryMax']
* @uses $GLOBALS['cfg']['MaxCharactersInDisplayedSQL']
* @uses PMA_getRelationsParam()
* @uses PMA_query_as_cu()
* @uses PMA_backquote()
@@ -726,6 +727,9 @@ function PMA_setComment($db, $table, $col, $comment, $removekey = '', $mode = 'a
*/
function PMA_setHistory($db, $table, $username, $sqlquery)
{
if (strlen($sqlquery) > $GLOBALS['cfg']['MaxCharactersInDisplayedSQL']) {
return;
}
$cfgRelation = PMA_getRelationsParam();
if (! isset($_SESSION['sql_history'])) {

View File

@@ -27,7 +27,6 @@
* @uses PMA_getRelationsParam()
* @uses PMA_isValid()
* @uses PMA_ifSetOr()
* @uses PMA_setHistory()
* @uses PMA_getHistory()
* @uses PMA_generate_common_url()
* @uses PMA_generate_common_hidden_inputs()