reverted. see rfe 867284

This commit is contained in:
Garvin Hicking
2004-01-05 16:10:15 +00:00
parent b65ba8b5db
commit 62de51e085
2 changed files with 9 additions and 3 deletions

View File

@@ -6,6 +6,8 @@ $Id$
$Source$ $Source$
2004-01-05 Garvin Hicking <returnofthegarv@supergarv.de> 2004-01-05 Garvin Hicking <returnofthegarv@supergarv.de>
* libraries/functions.js: Reverted row marker patch. See RFE #867284
for details.
* libraries/display_tbl.lib.php, libraries/display_tbl_links.lib.php, * libraries/display_tbl.lib.php, libraries/display_tbl_links.lib.php,
libraries/functions.js: Upon clicking on a result row, de/activate libraries/functions.js: Upon clicking on a result row, de/activate
the checkbox next to it. Only makes sense for horizontal mode. Can be the checkbox next to it. Only makes sense for horizontal mode. Can be

View File

@@ -423,7 +423,11 @@ function setPointer(theRow, theRowNum, theAction, theDefaultColor, thePointerCol
else if (theAction == 'click' && theMarkColor != '') { else if (theAction == 'click' && theMarkColor != '') {
newColor = theMarkColor; newColor = theMarkColor;
marked_row[theRowNum] = true; marked_row[theRowNum] = true;
document.getElementById('id_rows_to_delete' + theRowNum).checked = true; // Garvin: deactivated onclick marking of the checkbox because it's also executed
// when an action (like edit/delete) on a single item is performed. Then the checkbox
// would get deactived, even though we need it activated. Maybe there is a way
// to detect if the row was clicked, and not an item therein...
// document.getElementById('id_rows_to_delete' + theRowNum).checked = true;
} }
} }
// 4.1.2 Current color is the pointer one // 4.1.2 Current color is the pointer one
@@ -435,7 +439,7 @@ function setPointer(theRow, theRowNum, theAction, theDefaultColor, thePointerCol
else if (theAction == 'click' && theMarkColor != '') { else if (theAction == 'click' && theMarkColor != '') {
newColor = theMarkColor; newColor = theMarkColor;
marked_row[theRowNum] = true; marked_row[theRowNum] = true;
document.getElementById('id_rows_to_delete' + theRowNum).checked = true; // document.getElementById('id_rows_to_delete' + theRowNum).checked = true;
} }
} }
// 4.1.3 Current color is the marker one // 4.1.3 Current color is the marker one
@@ -447,7 +451,7 @@ function setPointer(theRow, theRowNum, theAction, theDefaultColor, thePointerCol
marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum]) marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])
? true ? true
: null; : null;
document.getElementById('id_rows_to_delete' + theRowNum).checked = false; // document.getElementById('id_rows_to_delete' + theRowNum).checked = false;
} }
} // end 4 } // end 4